Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qc.py for filter komplexity id bug #430

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

naomiwilson
Copy link
Contributor

@naomiwilson naomiwilson commented Dec 1, 2023

  • I have run pytest .tests/ on a local deployment and the tests passed successfully
  • If this adds a new output file, I have added a check to .tests/targets.txt
  • If this fixes a bug, I have added or modified an appropriate test
  • If this adds or modifies a rule that uses FASTQ files, the input accepts gzipped FASTQ and outputs gzipped FASTQ, or marks uncompressed FASTQ output as temp

If this is for a release:

  • I have updated documentation
  • I have updated all conda pin files (snakedeploy pin-conda-envs workflow/envs/*.yml)
  • I have updated the hardcoded version at the top of install.sh to match what this release's version will be
  • I have created a release archive that will be attached to this release (bash dev_scripts/generate_archive.sh)

@naomiwilson naomiwilson marked this pull request as ready for review December 1, 2023 00:55
@naomiwilson naomiwilson changed the title Update qc.py Update qc.py for filter komplexity id bug Dec 1, 2023
@Ulthran Ulthran merged commit 7a6979c into sunbeam-labs:main Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants