Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
nsvg
library which is based offnanosvg
to save the export svg string as a png. So that the output forsave_svg
andsave_png
are exactly the same.One small change is that
fill-opacity
andstroke-opacity
are used for the alpha value instead ofrgba
. This is because despite using theimage::ColorType::Rgba8
the alpha channel is not converted properly when saving the image. I suspect this because the actualnsvg
library doesn't supportrgba()
colours as I got exactly the same error when testing theresvg
library of a black image. Theresvg
converts the svg input into a svg just made up ofpaths
allowing you to see the intermediate representation. That showedstroke="none"
thereforergba
colour was the issue I think and that changing it fixed it.