Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some spiral examples #262

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

autotunafish
Copy link

Sketches for a logarithmic spiral, a logarithmic 3d effect spiral, Fibonacci spiral and the Ulam Prime spiral as well as some sample images

Images of example output
Images of example output
added spiral examples: ulamspiral, logspiral. three_d_spirals and fibonacci
@sunjay
Copy link
Owner

sunjay commented Aug 2, 2022

Thanks for making this! I haven't been actively maintaining this project for a while so I won't have time to review in depth. I took a cursory look and it looks fine overall. Have another look at the diff and let me know when you're satisfied with it. I'll merge it in when you're ready.

I don't think the build will pass right now but as long as you have it working locally it should be good to go.

@autotunafish
Copy link
Author

autotunafish commented Aug 2, 2022

Ok, cool. I forked the repo and compiled and rendered those images yesterday in the current version. I had originally written them in the older style described on the turtle website and following that method only barely worked as it would panic randomly and often crash if I moved the mouse. So seeing the build failures here made sense but pulling down the latest version and after I had refactored the example code with the newer methods to work properly it actually ran (seemingly) pretty stable or at least by comparison.

@sunjay
Copy link
Owner

sunjay commented Aug 2, 2022

Yeah, the version on crates.io is years old at this point and the dependencies there don't work at all. #183 details why we haven't released the current version in the repo that fixes some of those problems (and introduces others).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants