Feature/prepare split #211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dankelleher
reviewed
Apr 9, 2023
| interface BlazeConfig { | ||
| pool: PublicKey; | ||
| bsolMint: PublicKey; | ||
| } | ||
|
|
||
| interface MarinadeConfig { |
There was a problem hiding this comment.
Is this in order to be able to remove the marinade sdk from our build?
There was a problem hiding this comment.
That could be a long-term idea. Right now it only reduces our dependency on it. i.e now we're able to derive the bsolTokenAccountAuthority without needing to have called initMarinade() first.
| return [marinade, marinadeState]; | ||
| } | ||
|
|
||
| // TODO |
There was a problem hiding this comment.
can you add some more detail here of what is remaining?
There was a problem hiding this comment.
That shouldn't be there. I'll remove it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TokenConfigin SunriseStakeClient.makeBlaze(),makeMarinade(),getTokenConfigthatinit()now depends on.getMpDetails(),getLpDetails(), .... thatdetails()now depends on.The external interface provided by SunriseStakeClient remains the same.