Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump node to 18 #613

Merged
merged 1 commit into from
Sep 18, 2023
Merged

feat: bump node to 18 #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: "16"
node-version: "18"

- run: |
npm clean-install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: "16"
node-version: "18"

- run: |
npm clean-install
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ on:

jobs:
publish:
# Must match glibc verison in node:16-bullseye
runs-on: ubuntu-20.04
# Must match glibc verison in node:18
runs-on: ubuntu-22.04
Comment on lines -8 to +9
Copy link
Member Author

@soedirgo soedirgo Sep 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how to test this, but:

  • ubuntu-20.04 uses glibc 2.31
  • ubuntu 22.04 uses glibc 2.35
  • node:16-bullseye uses glibc 2.31
  • node:18 uses glibc 2.36

So this is as close as it gets.

steps:
- uses: actions/checkout@v3
with:
Expand All @@ -15,7 +15,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'

- run: npm i
- run: npm run binary:build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'

- run: |
npm clean-install
Expand All @@ -43,7 +43,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'

- name: Prepare release
run: |
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:16-bullseye as build
FROM node:18 as build
WORKDIR /usr/src/app
# Do `npm ci` separately so we can cache `node_modules`
# https://nodejs.org/en/docs/guides/nodejs-docker-webapp/
Expand All @@ -7,7 +7,7 @@ RUN npm clean-install
COPY . .
RUN npm run build && npm prune --omit=dev

FROM node:16-bullseye-slim
FROM node:18-slim
WORKDIR /usr/src/app
COPY --from=build /usr/src/app/node_modules node_modules
COPY --from=build /usr/src/app/dist dist
Expand Down
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"test:update": "run-s db:clean db:run && node --experimental-vm-modules node_modules/jest/bin/jest.js --runInBand --updateSnapshot && run-s db:clean"
},
"engines": {
"node": ">=16",
"node": ">=18",
"npm": ">=8"
},
"jest": {
Expand Down Expand Up @@ -75,7 +75,7 @@
"devDependencies": {
"@types/crypto-js": "^4.1.1",
"@types/jest": "^29.2.4",
"@types/node": "^16.18.3",
"@types/node": "^18.17.17",
"@types/pg": "^8.6.5",
"@types/pg-format": "^1.0.1",
"@types/prettier": "^2.7.3",
Expand Down
Loading