fix: bump to fastify 5 and resolve vulnerabilities #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevcodez
commented
Nov 5, 2024
src/lib/Parser.ts
Outdated
| @@ -35,7 +33,7 @@ interface ParseReturnValues { | |||
| */ | |||
| export function Deparse(parsedSql: object): DeparseReturnValues { | |||
| try { | |||
| const data = deparse(parsedSql) | |||
| const data = deparse(parsedSql, {}) | |||
There was a problem hiding this comment.
Types were erroring out, we can alternatively do ts-ignore
There was a problem hiding this comment.
Fixed it using class directly instead, as it's the same thing under the hood: https://github.com/launchql/pgsql-parser/blob/f1df82ed4358e47c682e007bc5aa306b58f25514/packages/deparser/src/deparser.ts#L258-L260
kamilogorek
force-pushed
the
fastify-5
branch
from
395797a to
c493f85
Compare
kamilogorek
approved these changes
Nov 5, 2024
|
No breaking changes in Fastify v5? I remember we had some upgrading to v4. |
|
Nothing that was used other than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.