fix: add dispose to auth client

supabase · Aug 15, 2024 · 4b400f0 · 4b400f0
1 parent e372c46
commit 4b400f0
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 0 deletions.
diff --git a/packages/gotrue/lib/src/broadcast_web.dart b/packages/gotrue/lib/src/broadcast_web.dart
@@ -7,5 +7,6 @@ BroadcastChannel getBroadcastChannel(String broadcastKey) {
   return (
     onMessage: broadcast.onMessage.map((event) => event.data.toString()),
     postMessage: broadcast.postMessage,
+    close: broadcast.close,
   );
 }
diff --git a/packages/gotrue/lib/src/gotrue_client.dart b/packages/gotrue/lib/src/gotrue_client.dart
@@ -1173,6 +1173,14 @@ class GoTrueClient {
     }
   }
 
+  void dispose() {
+    _onAuthStateChangeController.close();
+    _onAuthStateChangeControllerSync.close();
+    _broadcastChannel?.close();
+    _refreshTokenCompleter?.completeError(AuthException('Disposed'));
+    _autoRefreshTicker?.cancel();
+  }
+
   /// Generates a new JWT.
   ///
   /// To prevent multiple simultaneous requests it catches an already ongoing request by using the global [_refreshTokenCompleter].

diff --git a/packages/gotrue/lib/src/types/types.dart b/packages/gotrue/lib/src/types/types.dart
@@ -1,6 +1,7 @@
 typedef BroadcastChannel = ({
   Stream<String> onMessage,
   void Function(String) postMessage,
+  void Function() close,
 });
 
 enum AuthFlowType {

diff --git a/packages/supabase/lib/src/supabase_client.dart b/packages/supabase/lib/src/supabase_client.dart
@@ -250,6 +250,7 @@ class SupabaseClient {
   Future<void> dispose() async {
     await _authStateSubscription?.cancel();
     await _isolate.dispose();
+    auth.dispose();
   }
 
   GoTrueClient _initSupabaseAuthClient({