fix: Updated gotrue types.dart to include slackOidc #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gotrue exported OAuthProvider doesn't currently include Slack OIDC provider option. Therefore, trying to pass OAuthProvider.slack to sign in will set the wrong "provider" url param.
dshukertjr
changed the title
Oskar-Nilsen-Roos
changed the title
Vinzent03
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix
What is the current behavior?
Trying to pass OAuthProvider.slack to sign in will set the
providerurl parameter value to"slack", though"slack_oidc"is needed to authenticate properly with Slack OIDC authentication option.What is the new behavior?
You're able to pass
OAuthProvider.slackOidcgiving you the correct url param in the authentication request url.Additional context
Gotrue exported
OAuthProviderdoesn't currently include Slack OIDC provider option.I had this verified by Supabase support when trying to figure out what was wrong with my auth setup (big thanks to Jenny Kibiri)