Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Keycloak Provider on signInWithIdToken #1068

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

Ppito
Copy link
Contributor

@Ppito Ppito commented Oct 21, 2024

What kind of change does this PR introduce?

Relate: #1045
Add Keycloak Provider on signInWithIdToken

What is the current behavior?

signInWithIdToken are only available for Google, Apple or Kakao

What is the new behavior?

Authorize Keycloak to use signInWithIdToken

Additional context

We need a transparent connection that uses the accessToken and idToken that provides us with keycloak authentication.
As the connection has already been established through our systems, we need to provide the authentication information to gotrue directly using the signInWithIdToken method.

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks good to me, but could we put keycloak at the end of each of them instead of at the beginning?

@Ppito
Copy link
Contributor Author

Ppito commented Oct 21, 2024

Yes, I'll do that.

@Ppito
Copy link
Contributor Author

Ppito commented Oct 21, 2024

done. :D

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks great!

@dshukertjr dshukertjr merged commit be998fd into supabase:main Oct 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants