Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(realtime_client): some realtime refactor #645

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

Vinzent03
Copy link
Collaborator

@Vinzent03 Vinzent03 commented Sep 26, 2023

Breaking changes

  • move types from realtime_channel.dart to types.dart
  • make the error parameter for .subscribe() non optional
  • make the status parameter for subscribe() an enum instead of a String
  • add some documentation to ChannelFilter, because I found no way to use an enum for ChannelFilter.event, because for broadcast it can be any string

I think that's it for now that can be type wise improved.

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks beautiful!

@Vinzent03 Vinzent03 merged commit 1cb7243 into next Sep 27, 2023
@Vinzent03 Vinzent03 deleted the refactor/realtime branch September 27, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants