Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use per client fetch instance #818

Merged
merged 3 commits into from
Jan 31, 2024
Merged

fix: Use per client fetch instance #818

merged 3 commits into from
Jan 31, 2024

Conversation

Vinzent03
Copy link
Collaborator

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

One global fetch instance is used for all storage clients.

What is the new behavior?

The fetch instance containing the custom http client is now per storage client.

Additional context

close #771

@Vinzent03 Vinzent03 changed the title fix: use per client fetch instance fix: Use per client fetch instance Jan 30, 2024
@Vinzent03 Vinzent03 requested a review from dshukertjr January 30, 2024 20:57
@dshukertjr dshukertjr merged commit 0f3182c into main Jan 31, 2024
9 of 10 checks passed
@dshukertjr dshukertjr deleted the fix/storage-fetch branch January 31, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage_client uses a global storageFetch which does not work with multiple clients
2 participants