fix: Upgrade web_socket_channel for supporting web: ^1.0.0 and therefore WASM compilation on web
#992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoextra
changed the title
web_socket_channel for supporting web: ^1.0.0 and therefore WASM compilation on webweb_socket_channel for supporting web: ^1.0.0 and therefore WASM compilation on web
dshukertjr
requested changes
Jul 29, 2024
|
Seems like I was a bit too fast with upgrading the linting dependecy which are not compatible with Dart version < 3.1 and fails tests, I will adjust to a non-breaking version. |
dshukertjr
reviewed
Jul 30, 2024
dshukertjr
reviewed
Jul 30, 2024
dshukertjr
reviewed
Jul 30, 2024
dshukertjr
reviewed
Jul 30, 2024
dshukertjr
reviewed
Jul 30, 2024
dshukertjr
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Upgrade the
web_socket_channelto^3.0.1which mostly serves as an upgrade path for the transitivewebdependency which otherwise causesweb_socket_channelto downgrade and prevent WASM support on the web platform.What is the current behavior?
When having
supabaseorsupabase_flutteras a project dependeny while relying onweb: ^1.0.0theweb_socket_channeldependeny would downgrade and WASM compilation isn't possible anymore.What is the new behavior?
This behavior seems to be migrated.
Additional context
The breaking changes don't affect the codebase. Tests passed locally. Additionally, one linting error got fixed.