Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handler: switch error and ctx params #151

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

marcuspoehls
Copy link
Member

This pull request switches the parameters of the error report, handle, render method:

// before
handle(ctx: HttpContext, error: Error)
report(ctx: HttpContext, error: Error)
render(ctx: HttpContext, error: Error)

// now
handle(error: Error, ctx: HttpContext)
report(error: Error, ctx: HttpContext)
render(error: Error, ctx: HttpContext)

@marcuspoehls marcuspoehls changed the base branch from 3.x to next-4.x November 3, 2023 08:18
@marcuspoehls marcuspoehls merged commit 6f0c483 into next-4.x Nov 3, 2023
2 checks passed
@marcuspoehls marcuspoehls deleted the error-handler-switch-params branch November 3, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant