Rework of ddc_read and some more ... #51
Conversation
IOFramebufferPortFromCGDisplayID from https://github.com/kfix/ddcctl/blob/master/DDC.h
we need a small reply delay to get correct data if the checksum is ok, we don't need a second read replyTransactionType is changed to kIOI2CSimpleTransactionType to get data from my Monitor give it a try ;)
|
I somehow missed this PR when creating #55. Maybe they can be consolidated? |
|
I think so, because they should almost be identical: |
|
@Saman-VDR looks like you just got some more changes merged in to ddcctl after I made my PR. My main concern in addition to the updated DDC is that it also needs the EDID fixes here: kfix/ddcctl@42acbde. |
|
By the way, are the hotkeys configurable or at least documented anywhere? |
|
Sadly, I merged my last changes from ddcctl into BrightnessMenulet only local and forgot about the pushing. It looks like kfix reworked the EDID function at the same time... I will take a closer look to this tomorrow. |
|
@zulu-entertainment @Saman-VDR have you seen @florianbeck's branch of this? He has configurable hotkeys in it. |
Hi, for me the App was not working correctly.
That’s why I done some changes…
ddc_read now uses kIOI2CSimpleTransactionType.
A small minReplyDelay of 10 is necessary but didn't freeze the system!
My Dell U2515H now works 100%, also with the new Color settings in the preferences window.
IOFramebufferPortFromCGDisplayID replaces CGDisplayIOServicePort.
The Auto-Brightness menu item will removed, if no LMU is available.
Global keyboard bindings are hardcoded for now (this should be more user friendly in the future).
Testers are welcome, specifically with a recognized monitor, where reading data was not possible.
Greetings
Marc