Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: hint that machines may time out due to region issue #3074

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

alichay
Copy link
Contributor

@alichay alichay commented Nov 29, 2023

Change Summary

What and Why: if your deploy times out while waiting for a machine to reach "started," it suggests changing the wait timeout only. This is misleading, as this error can sometimes be caused by hosts that are having issues.

How: This shares the blame a bit, telling users that this could also be due to a region issue, giving them more to work off of.

Related to: https://github.com/superfly/reflyability/issues/12


Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

@benwaffle
Copy link
Contributor

Maybe there's a way to pass the cause through the context here? https://flyio.discourse.team/t/death-to-context-cancelled/4461/3

@alichay
Copy link
Contributor Author

alichay commented Nov 30, 2023

Maybe there's a way to pass the cause through the context here? https://flyio.discourse.team/t/death-to-context-cancelled/4461/3

In this case, the less-than-useful "context canceled" error is intercepted and changed out. I think there's value in making the error message clearer, but running the plumbing to get these functions to work with WithTimeoutCause would probably reduce code quality instead of improve it.

@alichay alichay merged commit b2f4319 into master Nov 30, 2023
41 of 42 checks passed
@alichay alichay deleted the feat/wait-start-timeout-is-host-err branch November 30, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants