Add fly volume snapshot create
#3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzys
force-pushed
the
create-volume-snapshot
branch
from
cfa59c1 to
a3beb23
Compare
|
Not ready for merge (because the backend is not there) but ready for review. |
dangra
reviewed
Dec 7, 2023
|
|
||
| cmd := command.New(usage, short, long, create, command.RequireSession) | ||
|
|
||
| cmd.Aliases = []string{"create"} |
There was a problem hiding this comment.
no need to alias the command name. It is "extracted" from usage field.
There was a problem hiding this comment.
TIL! Fixed in the last revision.
dangra
approved these changes
Dec 7, 2023
kzys
force-pushed
the
create-volume-snapshot
branch
2 times, most recently
from
4cb580f to
8d77cb6
Compare
This new command is used to snapshot volumes on-demand.
kzys
force-pushed
the
create-volume-snapshot
branch
from
8d77cb6 to
0cc2b03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new command is used to snapshot volumes on-demand.
Change Summary
What and Why: Adding a new command to snapshot volumes on-demand. In addition to daily snapshots, customers are now able to take arbitrary number of snapshots.
How: By adding the functionality on the server-side. In other words, we cannot merge the PR until we update the servers.
Related to:
Documentation