Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: don't persist "exec" if it's been removed from config #3093

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

alichay
Copy link
Contributor

@alichay alichay commented Dec 4, 2023

Change Summary

What and Why: If you specify this in your app config:

[experimental]
  exec = ["sleep", "inf"]

deploy, then remove the whole experimental section, subsequent deploys would still deploy machines with sleep inf as their command. This PR should prevent that from happening.


Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

@alichay alichay merged commit d371c8f into master Dec 5, 2023
41 of 42 checks passed
@alichay alichay deleted the bugfix/deploy/dont-keep-removed-exec branch December 5, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants