Support all VMSizeFlags in fly postgres create
#4216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #4158
Change Summary
Before this change,
fly postgres create
only supported a set of bespoke VM sizes via the --vm-size flag, making it impossible to create a postgres cluster with, say, 1 shared CPU and 1 GB of memory.As of this change, we create the underlying machine using the entire
MachineGuest
set of options, which allows for additional customization.The legacy prompt and error behavior given no
--vm-size
or an invalid--vm-size
is preserved.Tested
--vm-size
only--vm-size
and--vm-memory
--vm-memory
only--vm-size
Documentation