Skip to content

Commit

Permalink
feat: increase minimum Python version to 3.10 (#249)
Browse files Browse the repository at this point in the history
* feat: add ipython to dev dependencies

* feat: increase minimum Python version to 3.10
lsorber authored Sep 14, 2024
1 parent 32c5f45 commit 4195186
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.9", "3.12"]
python-version: ["3.10", "3.12"]
project-type: ["app", "package"]

name: Python ${{ matrix.python-version }} ${{ matrix.project-type }}
@@ -27,12 +27,12 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.9"
python-version: "3.10"

- name: Scaffold Python project
run: |
pip install --no-input cruft
cruft create --no-input --extra-context '{"project_type": "${{ matrix.project-type }}", "project_name": "My Project", "python_version": "3.9", "__docker_image":"radixai/python-gpu:$PYTHON_VERSION-cuda11.8", "with_fastapi_api": "1", "with_typer_cli": "1"}' ./template/
cruft create --no-input --extra-context '{"project_type": "${{ matrix.project-type }}", "project_name": "My Project", "python_version": "3.10", "__docker_image":"radixai/python-gpu:$PYTHON_VERSION-cuda11.8", "with_fastapi_api": "1", "with_typer_cli": "1"}' ./template/
- name: Set up Node.js
uses: actions/setup-node@v4
Original file line number Diff line number Diff line change
@@ -63,6 +63,7 @@ typeguard = ">=4.2.1"
[tool.poetry.group.dev.dependencies] # https://python-poetry.org/docs/master/managing-dependencies/
cruft = ">=2.15.0"
ipykernel = ">=6.29.4"
ipython = ">=8.23.0"
ipywidgets = ">=8.1.2"
pdoc = ">=14.4.0"
{%- if cookiecutter.private_package_repository_name %}

1 comment on commit 4195186

@r-dh
Copy link
Contributor

@r-dh r-dh commented on 4195186 Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of ipython = ">=8.23.0" conflicts with commitizen and prevents the Docker image to build successfully.

  • commitizen requires questionary (>=2.0,<3.0).
  • questionary (2.0.0 and 2.0.1) depend on prompt_toolkit (>=2.0,<=3.0.36).
  • ipython (>=8.23.0) depends on prompt_toolkit (>=3.0.41,<3.1.0).

Conflict: prompt_toolkit (>=3.0.41,<3.1.0) required by ipython (>=8.23.0) is incompatible with prompt_toolkit (<=3.0.36) required by questionary (and thus commitizen).

I found that ipython version >=8.18.0 is compatible with commitizen.

Please sign in to comment.