Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conflicting dependencies between ipython and commitizen #252

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

r-dh
Copy link
Contributor

@r-dh r-dh commented Sep 24, 2024

The earlier addition of ipython = ">=8.23.0" conflicts with commitizen and prevents the Docker image to build successfully.

  • commitizen requires questionary (>=2.0,<3.0).
  • questionary (2.0.0 and 2.0.1) depend on prompt_toolkit (>=2.0,<=3.0.36).
  • ipython (>=8.23.0) depends on prompt_toolkit (>=3.0.41,<3.1.0).

Conflict: prompt_toolkit (>=3.0.41,<3.1.0) required by ipython (>=8.23.0) is incompatible with prompt_toolkit (<=3.0.36) required by questionary (and thus commitizen).

I found that ipython version >=8.18.0 is compatible with commitizen.

The earlier addition of `ipython = ">=8.23.0"` conflicts with commitizen and prevents the Docker image to build successfully.

 - `commitizen` requires `questionary (>=2.0,<3.0)`.
 - `questionary (2.0.0 and 2.0.1)` depend on `prompt_toolkit (>=2.0,<=3.0.36)`.
  - `ipython (>=8.23.0)` depends on `prompt_toolkit (>=3.0.41,<3.1.0)`.

**Conflict:** `prompt_toolkit (>=3.0.41,<3.1.0)` required by `ipython (>=8.23.0)` is incompatible with `prompt_toolkit (<=3.0.36)` required by `questionary` (and thus `commitizen`).

I found that `ipython` version  `>=8.18.0` is compatible with commitizen.
@lsorber lsorber merged commit f74a028 into superlinear-ai:main Oct 8, 2024
4 checks passed
@lsorber lsorber changed the title fix: Conflicting dependencies between ipython and commitizen fix: conflicting dependencies between ipython and commitizen Oct 8, 2024
@lsorber
Copy link
Member

lsorber commented Oct 8, 2024

Thank you for the contribution @r-dh!

vanolucas added a commit to vanolucas/cookiecutter-poetry that referenced this pull request Nov 17, 2024
* feat: prefer mypy daemon (superlinear-ai#245)

* fix: remove deprecated ruff imports feature (superlinear-ai#246)

* feat: add GitHub Codespaces badge (superlinear-ai#247)

* docs: update ruff hyperlink (superlinear-ai#248)

docs: update Ruff hyperlink

* feat: increase minimum Python version to 3.10 (superlinear-ai#249)

* feat: add ipython to dev dependencies

* feat: increase minimum Python version to 3.10

* fix: update ruff log level (superlinear-ai#250)

* fix: conflicting dependencies between ipython and commitizen (superlinear-ai#252)

* chore: replace Radix with Superlinear (superlinear-ai#251)

Co-authored-by: Xavier Goás Aguililla <[email protected]>

* feat: remove CI/CD, add PostgreSQL + Adminer options (#1)

* feat: removed CI/CD, added PostgreSQL and Adminer options

* fix(LICENSE): typo in name

* chore: documented new cookiecutter options

* chore: add `poetry install` instruction in README

* chore: add poe lint/test instructions to README

* feat: add Streamlit app option to cookiecutter (#2)

* feat: add with_streamlit cookiecutter option

* chore: rename with_streamlit cookiecutter var

* feat: add VSCode debug launch config

* chore: update LICENSE date

* chore(README): fixed syntax

* refactor(docker-compose): remove version (deprecated)

* feat: removed GitHub test flow

---------

Co-authored-by: Laurent Sorber <[email protected]>
Co-authored-by: r-dh <[email protected]>
Co-authored-by: Xavier Goás Aguililla <[email protected]>
Co-authored-by: Xavier Goás Aguililla <[email protected]>
soxguy pushed a commit to soxguy/poetry-cookiecutter that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants