This repository has been archived by the owner on Mar 5, 2021. It is now read-only.
Various fixes to be able to put superpowers inside the flatpak sandbox #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --rw-data-path is used to point to the directory where we can write some files (like settings). The server will also use this directory through the new --rw-data-path flag.
Flatpak itself should care about possible updates.
We will definitely need the LD_LIBRARY_PATH env var, so the dynamic
linker can find the libgtk-x11 library, but we also pass some more
variables that point to paths somewhere in ${HOME}/.var or /app.
For flatpak we are not interested in building superpowers for mac or windows, only for linux. So now we can run "npm run package linux ia32" to build package for 32bit linux. The values for the parameters are the same as the ones electron packager takes for its platform and arch options.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends currently on the PR in core - superpowers/superpowers-core#158
We also disable updates when we are inside the flatpak, as the flatpakked app already has the app, core and the game system with the plugins inside the read only directory (
/app).Also, we need to pass more env vars to the server, because inside the flatpak sandbox, libraries coming from the project or its dependencies are put inside
/app, but the libraries from the runtime are inside/lib(for example the gtk2 library). The linker knows about both of those locations thanks to theLD_LIBRARY_PATHenv var. I'm also forwarding all the variables that point to the directories set up by flatpak.