feat: Rdo 6 1 liner sdk examples #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@John-Memphis can you resolve the conflict? |
|
@bazen-teklehaymanot I will resolve it. I meant to make this a draft PR |
|
@John-Memphis all checks should pass before review |
shay23b
requested changes
Jan 15, 2024
| options.Username = "test_user"; | ||
| options.Password = Environment.GetEnvironmentVariable("memphis_pass"); | ||
| options.Host = "<memphis-host>"; | ||
| // options.AccountId = "<memphis-accountId>"; |
There was a problem hiding this comment.
why is it in a comment? maybe needs another comment - for cloud users
There was a problem hiding this comment.
@shay23b because it errors if I don't put it in a comment. I don't want to put it in a string because it's not a string (it's an int), but I also can't leave it uncommented because it will error.
I looked at the old examples and this was how this was treated to get past the linter complaining about the quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.