fix: broken search filters and login method modal

[ohansFavour]

Summary of Change

Change includes UI/UX improvements focusing on login method management and search functionality fixes across multiple dashboard tabs.

Problem Statement

1. Login Method Management Issues:

   • Delete button visibility was broken when only one login method existed
   • Modal messaging for login method deletion needed clarity improvements

2. Search Functionality Issues:

   • Search feature was not working properly in the User Management tab
   • Search feature was not working properly in the Tenant Management tab

Summary of Solution

1. Login Method UI Fixes:

   • Fixed visibility logic for the delete button to ensure it doesn't appear with single login methods
   • Enhanced the modal message content for login method deletion to improve user understanding

2. Search Functionality Improvements:

   • Resolved search functionality issues in the User Management interface
   • Fixed search mechanism in the Tenant Management section

https://www.loom.com/share/eb9df9b5d20f4f16bfff2af1cbb17cee

Related issues

• Link to issue1 here
• Link to issue1 here

Test Plan

Tested on all primary browsers for:

• Chrome
  • Desktop
  • Mobile
  • Tablet
• Safari
  • Desktop
  • Mobile
  • Tablet
• Firefox
  • Desktop
  • Mobile
  • Tablet
• (Optional) Tested on Safari 12 (Physical or emulator)
  • iPad
  • iPhone
• (Optional) Tested on physical mobile and tablet device for:
  • Android
  • iOS (including iPadOS)

Feature tests:

• Dashboard Admin access.

  • Test all the POST, PUT and DELETE endpoints with admins only access enabled for the dashboard recipe.
  • Test all POST, PUT and DELETE endpoints without the admins only access enabled.

• Search

  • Search with anything that results in an empty state in the UI (Should show an empty state explaining that there were no results)
  • Search with an empty string (Dashboard should not allow this)
  • Email search
    • Serach for "e" with email tag and then delete the tag (Should show one user initially then show all with pagination enabled)
    • Search for "test" with the email tag (Expect 14 results)
    • Search with "g" for email tag (Expect 3 results)
    • Search with "g" and "p" for email tag (Expect 3 results)
    • Search with "g" and "t" for email tag, then delete "t" (Expect 17 results initially, then 3)
    • Search with "@" for email tag (Expect 0 results (This is because at the time of adding this case we would only check for the start of the email or the domain and not any character inside the full email))
    • Search for "[email protected]" with email tag (Expect 1 result)
    • Search for "[email protected]" with email tag (Expect 3 results)
    • Search for "gmail" with email tag (Expect 3 results)
    • Search for "ABC" with email tag (Expect 0 results)
    • Search for "a" with email tag (Expect 0 results (This is because at the time of adding this we only check if the email starts with the query and not contains))
    • Search for "team" with email tag (Expect 0 results)
    • Search for "782" with email tag (Expect 1 result)
  • Phone search
    • Search for "1" with phone tag (Expect 3 results)
    • Search for "+1" with phone tag (Expect 3 results)
    • Search for "91" with phone tag (Expect 1 result)
    • Search for "291" with phone tag (Expect 0 results)
    • Search for "+12" with phone tag (Expect 2 results)
    • Search for "5" with phone tag (Expect 0 results)
    • Search for "1(" with phone tag (Expect 0 results (This is because we render phone numbers with brackets so users may end up searching with that))
  • Provider search
    • Search for "g" with provider tag (Expect 5 results)
    • Search for "gi" with provider tag (Expect 2 results)
    • Search for "t" with provider tag (Expect 0 results)
    • Search for "google" with provider tag (Expect 3 results)
  • Combination testing
    • Search with "g" for email tag and "g" for provider tag (Expect 1 result)
    • Search for "github" with provider tag and "782" with email tag (Expect 1 result)
    • Search for "github" and "google" with provider tag (Expect 5 results)
    • Search for "j" and "g" with email tag (Expect 6 results)
    • Search for "1" and "91" with phone tag (Expect 4 results)
    • Search with "google" for provider tag and "1" for phone tag (Expect 0 results)
    • Search for "g" with email tag and "1" with phone tag (Expect 0 results)
    • Search for "k" with provider and "a", "g", "b" (in that order) for email (Expect 0 resutls)

• General UI testing

  • Test that emty state renders fine (no overflow, no UI glitches, responsiveness etc)
  • Test that the list renders fine (no overflow, no UI glitches, responsiveness etc)
  • Test that pagination is visiable and usable (There should be at least 2 pages worth of users)
  • Test that the list only shows 10 users at a time
  • Test that for users with no accounts linked the auth method i nthe list is correct
  • Test that for users with multiple login methods, the auth method shows correctly
  • Test that search is visible if the feature is enabled

• Multi tenant testing

  • Create one tenant (tenant1), and add 3 users to them. In the dashboard, when you switch to that tenant, it should list those users.
  • Create a user in tenant1 and using backend sdk's(Go, Python, Node) associate the user to a different tenant and select that tenant on the dashboard from the tenants dropdown, it should show that user in the list

• User Roles and Permissions testing

  • UserRoles page testing
    • Test the empty state when there are no roles created on the roles page.
    • Test creation, delete and updating functionality of the roles are working properly.
    • Test pagination of the roles list with more than 2 or 3 pages of data atleast.
    • Test that the permissions per role are rendering properly without overflowing the parent table.
    • Check for the feature_not_enabled state on both userDetails page and user roles page.
  • userDetails page testing with respect to roles and permissions.
    • Test adding and deleting roles to a user.
    • Test the roles search feature and make sure that the list does not include any assigned roles in it.
    • Test by associating the user with multiple tenants and assigning roles to the user in each tenant separately.

• User creation

  • Test without initializing any recipes on the backend SDK and ensure that the UI responds with correct alert errors.
  • Ensure the relevant warning message is shown while switching between authentication methods.
  • EmailPassword user creation.
    • Test EmailPassword user creation by enabling both emailpassword and thirdpartyemailpassword together and individually.
    • Test with custom form field validators; make sure that the overrides are working properly.
    • Test default email and password validations to ensure they are working properly.
    • Test that no duplicate users are created with the same email address.
  • Passwordless user creation.
    • Test Passwordless user creation by enabling both passwordless and thirdpartypasswordless together and individually.
    • Test creating a user with different contactMethod's ensure that the frontend displays relevant UI based on the contactMethod selected.
    • Test default email and phoneNumber validations to ensure they are working properly.
    • Test user-defined custom email and phoneNumber validators to ensure they are working properly.
  • Test AccountLinking by creating an emailpassword and passwordless user with the same email and make sure that the accounts are linked.

• User details

  • Can edit email of non third party login method if there is only 1 login method for the user
  • Can edit email of non third party login method if there are >= 2 login methods for the user
  • Deleting a non primary login method for a user only deletes that login method, and not the whole user
  • Deleting a primary login method for a user deletes only that primary login method and not the user
  • Deleting a user deletes all the login methods for that user as well

• Tenant Management

  • Tenant Listing page
    • There should be only one tenant by default (public) and the login methods should be same as what is initialised in the SDK
      • Initialise only thirdparty and emailpassword recipe and check if only emailpassword and thirdparty is shown for the public tenant
      • Initialise passwordless with different contact methods and flow type and ensure the factor toggles are reflected as per what is initialised
    • Create a new tenant
      • Should display an error message if multitenancy license is not added to the core
      • Should be able to create tenant once the multitenancy license is added to the core
      • Should not be able to create tenants with some stop words like recipe, config, hello, appid-t1
      • Should not be able to create tenants with special characters in the name
      • When creating a tenant with capital letters, it should automatically convert to lowercase once the tenant is created
      • For newly created tenant, no recipes should be enabled by default
      • Creating more than 10 tenants should show pagination
      • Creating existing tenant id should show an error
    • Tenant search and pagination
      • Should be able to search for tenants
      • Tenant search should be case insensitive
      • Tenant search should match if the sub-string is in the middle of the tenant name
      • When tenant search matches with more than 10 tenants, pagination should still be active
      • When there is a search term, click on a tenant and then come back to the tenant listing page. The search term should remain.
    • Tenant details
      • The whole tenant row must be clickable and on click should take to tenant details page
      • Create some users for the tenant and ensure user count matches
      • See users button must take you to users listing page with the tenant selected on a new window
      • Should see a warning when no login methods are enabled
      • Enabled login methods
        • Should be able to toggle only login methods based on the initialised recipes
          • if only thirdparty and emailpassword recipe is initialised, should not be able to turn on any of the passwordless login methods (otp-phone, otp-email, etc)
          • if passwordless is initialised with contact method email only, should not be able to turn on otp-phone, link-phone
        • should be able to turn off all login methods
      • Secondary login methods
        • With mfa not initialised, should not be able to turn on any secondary login methods
        • Should be able to toggle only login methods based on initialised recipes
          • If passwordless is not initialised, should not be able to turn on otp-phone
          • If totp is not initialised, should not be able to turn on totp
          • If passwordless is initialised with contact method email only, should not be able to turn on otp-phone
          • Once all the recipes are initialised, should be able to turn on/off all the secondary login methods
      • Social/Enterprise logins
        • This section should not be visible if thirdparty login method is turned off
        • This section should be visible if thirdparty login method is turned on
        • With static provider list
          • The static provider list should show up by default for all the tenants
          • Should be able to delete third party providers from static list
          • When deleting the last one, thirdparty should get disabled
          • When there are no providers for a tenant, when turning on thirdparty login method, a popup to add a third party provider should be shown
        • For creating Enterprise providers, there should be an additional step where the user has to provide directoryId or okta domain, etc. When a valid value is entered, the OIDC endpoint and other endpoints should be populated automatically.
          • If directoryId or okta domain is invalid, appropriate error message should be shown
        • In the thirdparty form, all the fields should be editable and persist correctly. Change every field, save and then go into edit mode again and check if the change has been persisted correctly.
        • Should be able to add all built-in providers. When adding provider, check relavant fields are already populated, like OIDC endpoint, authorization endpoint, token endpoint, etc.
        • Clients list
          • Should be able to add / remove clients in any order
          • Client Type should be required whenever there are more than 1 clients
          • Minimum one client should be required
          • Should not be able to save when required fields are not filled
        • Fake email generation
          • Should ask for fake email generation when Sometimes option is selected for How often does the provider return email?
          • Should not ask for fake email generation when Always option is selected for How often does the provider return email?
          • Should not ask for fake email generation when Never option is selected for How often does the provider return email?
            • Select never option and save the provider. Come back into edit mode of this, we should see that the option is Sometimes and the fake email generation is set to true

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

• Changelog has been updated
• Changes to the version if needed
  • In package.json
  • In package-lock.json
  • In src/version.ts
• Had run npm run build
• Had installed and ran the pre-commit hook

Remaining TODOs for this PR

• Item1
• Item2