Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: thirdparty rework #522

Merged
merged 155 commits into from
Mar 22, 2023
Merged

feat: thirdparty rework #522

merged 155 commits into from
Mar 22, 2023

Conversation

sattvikc
Copy link
Contributor

@sattvikc sattvikc commented Nov 24, 2022

Summary of change

Related issues

  • Link to issue1 here
  • Link to issue1 here

Checklist

  • Algolia search needs to be updated? (If there is a new sub docs project, then yes)
  • Sitemap needs to be updated? (If there is a new sub docs project, then yes)
  • Checked for broken links? (Run cd v2 && MODE=production npx docusaurus build)
  • Changes required to the demo apps corresponding to the docs?

Remaining TODOs for this PR

@sattvikc sattvikc self-assigned this Nov 24, 2022
@netlify
Copy link

netlify bot commented Nov 24, 2022

Deploy Preview for admiring-bhabha-7b1be9 ready!

Name Link
🔨 Latest commit 4562bdf
🔍 Latest deploy log https://app.netlify.com/sites/admiring-bhabha-7b1be9/deploys/641ade28bfb49c0008f7ac8c
😎 Deploy Preview https://deploy-preview-522--admiring-bhabha-7b1be9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -0,0 +1,7 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a page called "Getting user info" under common customisation. So that page needs to be changed to add the stuff here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page is about accessing the rawUserInfoFromProvider. The other page "Getting user info" talks about getUserByEmail and getUserById

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea but from the user's point of view, it's about getting info about the user - their social profile info also counts as info about the user.

Thing from the user's points of view please.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed doing this @sattvikc ?

@rishabhpoddar
Copy link
Contributor

@sattvikc sattvikc changed the base branch from master to feat/tp-rework December 29, 2022 05:49
@rishabhpoddar rishabhpoddar marked this pull request as ready for review March 9, 2023 08:53
@rishabhpoddar rishabhpoddar merged commit 1620d2b into feat/tp-rework Mar 22, 2023
@rishabhpoddar rishabhpoddar deleted the tp-rework branch March 22, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants