Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: make the mfa screens do success redirection if the next array is empty #851

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

porcellus
Copy link
Collaborator

@porcellus porcellus commented Aug 23, 2024

Summary of change

  • Changed redirectToFactor to accept an object instead of multiple arguments.
  • Changed redirectToFactorChooser to accept an object instead of multiple arguments.
  • Made MFA related screens do a success redirection if MFA is already completed and the stepUp query param is not set to true.
    • redirectToFactorChooser now accepts a stepUp option to set the stepUp query param.
    • redirectToFactor now accepts a stepUp option to set the stepUp query param.

Related issues

Test Plan

Updated existing tests/the test app to use the stepUp query param by default
Added new tests that check the redirection happens if the new query param is not added

Documentation changes

Docs PR

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs
  • If I added a new login method, I modified the list in lib/ts/types.ts
  • If I added a factor id, I modified the list in lib/ts/recipe/multifactorauth/types.ts

Copy link

github-actions bot commented Aug 23, 2024

size-limit report 📦

Path Size
lib/build/index.js 22.69 KB (+0.54% 🔺)
recipe/session/index.js 23.45 KB (+0.46% 🔺)
recipe/session/prebuiltui.js 27.88 KB (+0.42% 🔺)
recipe/thirdparty/index.js 31.33 KB (0%)
recipe/emailpassword/index.js 11.07 KB (0%)
recipe/emailverification/index.js 7.84 KB (+0.02% 🔺)
recipe/passwordless/index.js 14.84 KB (+0.59% 🔺)
recipe/emailverification/prebuiltui.js 32.53 KB (+0.34% 🔺)
recipe/thirdparty/prebuiltui.js 51.13 KB (+0.33% 🔺)
recipe/emailpassword/prebuiltui.js 38.7 KB (+0.45% 🔺)
recipe/passwordless/prebuiltui.js 125.9 KB (+0.17% 🔺)
recipe/multitenancy/index.js 6.67 KB (+0.02% 🔺)
recipe/multifactorauth/index.js 10.9 KB (+1.25% 🔺)
recipe/multifactorauth/prebuiltui.js 31.57 KB (+0.72% 🔺)

@porcellus porcellus changed the base branch from 0.45 to 0.46 August 23, 2024 23:23
@porcellus porcellus merged commit 7990896 into 0.46 Aug 23, 2024
22 of 36 checks passed
@porcellus porcellus deleted the feat/mfa_redirect branch August 23, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant