Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Normalise phoneNumber received in the input before processing + Migration script #885

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

anku255
Copy link
Contributor

@anku255 anku255 commented Nov 20, 2023

Summary of change

This PR introduces phone number normalisation to all API endpoints that accept phone numbers as user input. The implementation includes the addition of a normaliseIfPhoneNumber function in the Utils class, which is now utilized across all relevant APIs.

This PR also introduces phone number normalisation migration script that is supposed to be run on the all the core instances after migrating to version 7.0.12.

See #881 , #882

Related issues

Test Plan

  • Tests are added for the normaliseIfPhoneNumber util function
  • Tests are added for every API that changed
  • Migration script was tested manual 200K rows for both PostgreSQL and MySQL databases

Checklist for important updates

  • Changelog has been updated
    • If there are any db schema changes, mention those changes clearly
  • coreDriverInterfaceSupported.json file has been updated (if needed)
  • pluginInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In build.gradle
  • If added a new paid feature, edit the getPaidFeatureStats function in FeatureFlag.java file
  • Had installed and ran the pre-commit hook
  • If there are new dependencies that have been added in build.gradle, please make sure to add them
    in implementationDependencies.json.
  • Update function getValidFields in io/supertokens/config/CoreConfig.java if new aliases were added for any core config (similar to the access_token_signing_key_update_interval config alias).
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the
      latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a foreign key constraint on app_id_to_user_id table, make sure to delete from this table when deleting the user as well if deleteUserIdMappingToo is false.

Sorry, something went wrong.

…881)

* feat: normalise phoneNumber received in the input before processing

* feat: PR changes

* feat: PR changes
* feat: Add migration script for phone number normalisation

* feat: PR changes

* feat: PR changes

* feat: PR changes

* feat: PR changes

* feat: PR changes

* feat: PR changes
@rishabhpoddar rishabhpoddar merged commit 6548d68 into 7.0 Nov 20, 2023
@rishabhpoddar rishabhpoddar deleted the feat/phone-number-normalisation-base branch November 20, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants