-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat!: Account linking #391
Draft
rishabhpoddar
wants to merge
31
commits into
0.17
Choose a base branch
from
feat/account-linking-base
base: 0.17
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
The progress so far is that we have implemented and tested all recipe functions for account linking +
verifyEmailForRecipeUserIfLinkedAccountsAreVerified
interal function in the accountLinkingRecipe.go file.There are also a few changes to existing recipes like thirdparty and email password to get the new tests to pass, however they need to be revisited.
Related issues
Test Plan
TODO
Documentation changes
TODO
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)supertokens/constants.go
frontendDriverInterfaceSupported.json
file has been updated (if needed)supertokens/constants.go > version variable
recipe/thirdparty/providers/config_utils.go
file,createProvider
function.git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.session/accessTokenVersions_test.go
to account for any new claims that are optional or omitted by the coreRemaining TODOs for this PR
recipe/dashboard/api/userdetails/userDelete.go
, we must fetchremoveAllLinkedAccounts
from the API input, as opposed to passing in true all the time.Additional notes:
account-linking-golang-track-keeping-local-branch
which has been modified to remove tests that have been implemented in the golang SDK. This way, we can keep track of which tests are pending to be implemented-This PR has files that are unviewed (from @rishabhpoddar account) which indicate that there is something from that file thats not implemented in golang already.