feat: ignore protected props in createNewSession* #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
10 tasks
rishabhpoddar
added a commit
that referenced
this pull request
Sep 20, 2023
* account linking changes (#425) * account linking changes * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/session/sessionClass.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/session/sessionFunctions.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * code review changes * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * code review changes * code review changes * code review changes * code review changes * code review changes * Update lib/ts/recipe/session/sessionFunctions.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes Co-authored-by: Rishabh Poddar <[email protected]> * Recipe interface changes regarding account-linking (#439) * EP recipe interface changes regarding account-linking * Update lib/ts/recipe/emailpassword/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/emailpassword/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/emailpassword/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * Update lib/ts/recipe/emailpassword/api/implementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/emailpassword/api/implementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/emailpassword/api/implementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/emailpassword/api/implementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/emailpassword/api/implementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/emailpassword/api/implementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * Update lib/ts/recipe/emailpassword/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/thirdpartyemailpassword/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes Co-authored-by: Rishabh Poddar <[email protected]> * thirdparty interface changes regarding account-linking (#443) * thirdparty interface changes regarding account-linking * Update lib/ts/recipe/thirdparty/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * code review changes Co-authored-by: Rishabh Poddar <[email protected]> * passwordless interface changes for account linking (#444) * passwordless interface changes for account linking * code review changes * feat: Account linking interface update (#463) * recipe interface changes for account linking * user context update * types update * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> Co-authored-by: Rishabh Poddar <[email protected]> * feat: Account linking recipe implementation (#466) * recipe interface changes for account linking * account linking implementation * user context update * code udpate * types update * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * return type update * index file updated * merge with account-linking interface * Update lib/ts/recipe/accountlinking/recipeImplementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * Update lib/ts/recipe/accountlinking/recipeImplementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * code review changes * code review changes * code review changes * review changes * recipeImplementation types update * merge with 13.0 * recipe implementation update * changes to dashboard recipe types * removes unnecessary functions exposed from account linking recipe * adds a precautionary check * small change * Update lib/ts/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/index.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/supertokens.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/dashboard/api/usersGet.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/index.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/index.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/index.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * mark email as verify if it is already verified in either primary user or the current recipe user * fixes and refactors * account linking: fixes bugs and refactors (#498) * fixes bugs and refactors * small refactors and fixes * small refactor * small type changes * review changes * removes redundant check * account linking: removes ANOTHER from canCreatePrimaryUserId status return type (#500) * removes ANOTHER from canCreatePrimaryUserId status return type * small change related to status change in primary user id creation * change to canLinkAccounts * Update lib/ts/recipe/accountlinking/recipeImplementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipeImplementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes --------- Co-authored-by: Rishabh Poddar <[email protected]> * chore: Account linking general refactor (#541) * Refactor status * Refactor unlink accounts return type * Move marking emails as verified logic to link accounts * Refactor * Rename ACCOUNT_INFO_ALREADY_LINKED_WITH_ANOTHER_PRIMARY_USER_ID_ERROR * fixes review comments --------- Co-authored-by: rishabhpoddar <[email protected]> * more review comment changes * type changes * feat: Emailpassword accountlinking (#501) * recipe interface changes for account linking * account linking implementation * user context update * code udpate * types update * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * return type update * index file updated * merge with account-linking interface * Update lib/ts/recipe/accountlinking/recipeImplementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * Update lib/ts/recipe/accountlinking/recipeImplementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * code review changes * code review changes * code review changes * review changes * sign-up post login updated * sign-up post login updated * sign-up API implementation update * import update * function import update * changes in signup recipeimplementation * recipeImplementation types update * merge with 13.0 * merge with account-linking implementation * recipe implementation update * account linking claim * changes to dashboard recipe types * removes unnecessary functions exposed from account linking recipe * adds a precautionary check * small change * Update lib/ts/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/index.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/supertokens.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/dashboard/api/usersGet.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/index.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/index.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/index.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * mark email as verify if it is already verified in either primary user or the current recipe user * fixes and refactors * account linking: fixes bugs and refactors (#498) * fixes bugs and refactors * small refactors and fixes * small refactor * small type changes * review changes * removes redundant check * account linking: removes ANOTHER from canCreatePrimaryUserId status return type (#500) * removes ANOTHER from canCreatePrimaryUserId status return type * small change related to status change in primary user id creation * change to canLinkAccounts * Update lib/ts/recipe/accountlinking/recipeImplementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipeImplementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * review changes * createdNewUser changes * adds comments * fixes * review changes (#511) * more changes * small changes * small changes * small changes * Update lib/ts/recipe/emailpassword/api/implementation.ts * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * more fixes - ts still not compiling * fixes all ts issues --------- Co-authored-by: Rishabh Poddar <[email protected]> * merges with latest (#559) * Emailverification accountlinking (#528) * email verification recipe changes for account linking * email verification recipe changes for account linking * email verification recipe changes for account linking * recipe interface changes for account linking * account linking implementation * user context update * code udpate * types update * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/types.ts Co-authored-by: Rishabh Poddar <[email protected]> * return type update * index file updated * merge with account-linking interface * Update lib/ts/recipe/accountlinking/recipeImplementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * Update lib/ts/recipe/accountlinking/recipeImplementation.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * Update lib/ts/recipe/accountlinking/recipe.ts Co-authored-by: Rishabh Poddar <[email protected]> * code review changes * code review changes * code review changes * code review changes * review changes * sign-up post login updated * sign-up post login updated * sign-up API implementation update * updating email verification api implementation * import update * function import update * changes in signup recipeimplementation * email verify get changes * recipeImplementation types update * merge with 13.0 * merge with account-linking implementation * merge with 13.0 * recipe implementation update * account linking claim * session claim update * session claim update * merges with latest * more changes * more changes * removes account linking claim post linkAccounts or createPrimaryUser function call * refactor * small change * small change * exposes help functions in account linking recipe * refactor and works on generate email verification token API * completes generate email verification token API * adds todos * more changes * refactor * removes unnecessary function from recipes * resolves a few todos * fixes dashboard api for email verification * fixes an issue where we tried linking account even in email verify get API * adds account linking in very email recipe function --------- Co-authored-by: Rishabh Poddar <[email protected]> * merges (#560) * merges * rebuilds docs * builds pretty * Account linking test fixes (#566) * gets tests to run * resets account linking between tests * fixes a test * adds mocking for a few APIs * more fixes * fixes more bugs * fixes a test * fixes more tests * fixes a small bug * enforces normlised checks when comparing account info in logic * fixes a test * fixes a few more tests * fixes more tests * fixes more tests * fixes more tests * more test fixes * more test fixes * more change * fixes more tests * more changes * adds id and recipeId to email verification sendEmail function * test fix * fixes more tests * fixes more tests * fixes more tests * more test fixes * fixes more tests * fixes more tests * fixes more tests * more test fixes * fixes more tests * more test fixes * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * small change to a test * fixes more tests * fixes more tests * some type changes * fixes cyclic dependency test * edits github acount to allow mocking * Account linking recipe primary user id types (#568) * WIP - fixes a few bugs, and adds adds the concept of a recipeUserId type * gets everything to compile * modifies tests * fixes tests * fixes more tests * fixes more tests * fixes more tests * fixes a test * fixes more tests * fixes more tests * fixes more tests * fixes more tests and adds a toJson function in the user object to convert recipe user id object type to a string in the json response * fixes more tests * fixes issue with allowing emial password sign up for a primary email * renames an API function name * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * Account linking tests (#572) * removes unnecessary recipe functions * adds primary user creation test' * adds test todos * adds test todos * adds more tests * adds more tests * adds more tests * more tests * more tests * more tests * adds more tests * more mocking * more tests * more tests * adds more tests * removes normalisedInputMap structure * more tests * adds more tests * changes impl of does email exist * more tests * adds more tests * adds more tests * more changes * adds auto marking of email verification based on linking * adds more tests * more tests * remove a todo * adds more tests * adds more tests * adds more tests * adds more tests * adds more tests * adds more tests * fixes a bug + adds more tests * adds more tests * adds more tests * adds more tests * adds more tests * adds more tests * adds more tests * changes path of API * small changes to dashboard related APIs * fixes a bug and adds more tests * adds more tests * adds more tests * more tests * more tests * adds more tests * adds more tests * adds more tests * adds more tests and adds recipe user id to password reset email send email function * moves check for isSignUpAllowed to api layer * renames a variable * adds more checks to allowSignUp function * modifies update email or password function * more tests * more tests * adds comments * adds more tests * adds more tests * adds comments * adds test cases skeleton * adds one test for password reset * adds more tests * adds more tests * adds more tests * more tests * adds more tests * adds more tests * adds more tests * adds more tests * adds more tests * adds more tests * adds more tests * adds more tests * adds more tests * adds more tests * enhances tests * starts working on session tests * fixes a test * adds more tests * adds more tests * renames a function * adds more tests * more tests * adds more tests * adds more tests * adds a TODO * adds more tests * removes unnecessary call to a function in email verification recipe * adds more tests * add new tests * add new tests * adds more tests * adds more tests * adds more tests * removes use of account linking claim (#577) * removes use of account linking claim * starts working on modifying tests * changes output of one API * changes output of an API * modifies tests * fixes tests * fixes tests * fixes tests * fixes more tests * adds mock reset to make tests pass * account linking third party (#579) * starts working on type changes * makes more progress * refactors a lot of code * gets everything to compile * starts fixing tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * fixes more tests * removes unnecessary code * fixes more tests * fixes more tests * fixes more tests * more tests * adds more checks * more tests * adds more tests * more tests * removes unnecessary code * adds more tests * changes status type to make it more clear * adds new param to listUsersByAccountInfo * more changes * adds more tests * fixes an issue * adds more comments * more changes * more changes * more changes * more changes * fixes a test * changes * changes * changes * adds comments and tests * adds more tests * renames a var * modifies API spec a bit * adds more tests * adds more tests * removes post sessison account linking API but keeps the function * adds a few more checks * fixes a few bugs * fixes tests * removes unneeded check * changes to sign in flow for third party and email password to check for email verification (#584) * adds missing checks * more changes * adds function for isSignInAllowed * adds isEmailVerified function * more refactor * adds a TODO * more changes * completes more todos * finishes more todos * adds account linking during sign in as well * more refactors * changes a comment * small changes * fixes a cyclic dependency issue * fixes a test * fixes tests * fixes a bug * more test fixes * more changes * fixes tests * fixes more tests * more changes * fixes tests * adds a new test * bug fixes * fixes cyclic dependency issues * more fixes * adds more tests * adds more tests * adds a comment * adds more tests * more tests * more changes * more tests * adds tests and fixes a bug * adds more tests * adds more tests * adds more tests * adds more tests * more tests * adds more tests * fixes a test * removes unnecessary console log * fixes a bug * a few fixes and edge cases * small bug fix * removes unused function * small changes * feat: smaller test&test based fixes for merge issues * feat: implement passwordless in account-linking (#664) * feat(account-linking): modify passwordless to support account-linking * refactor: move email verification into recipe impl + extend tests * feat: smaller test&test based fixes * feat: integrate with CDI 4.0 (#665) * feat(account-linking): modify passwordless to support account-linking * refactor: move email verification into recipe impl + extend tests * feat: smaller test&test based fixes * feat: removed account-to-link table related functions/props * fix: cleanup & test fixing * feat: fix core integration * test: update tests to match interface after account-linking * fix: minor fix for getsession api in dashboard recipe (#666) * minor fix for getsession api in dashboard recipe * build again to remove logs * fix: add missing serialization in userDetailsGET * feat: fixing checklist items (#669) * feat(account-linking): modify passwordless to support account-linking * refactor: move email verification into recipe impl + extend tests * feat: smaller test&test based fixes * feat: removed account-to-link table related functions/props * fix: cleanup & test fixing * feat: fix core integration * test: update tests to match interface after account-linking * feat: removed unused session parameter from shouldDoAccountLinkingResponse * feat: add the linked user to the linkAccounts results * feat: make userContext normalization more consistent * test: check that passwordless.consumeCode marks the email as verified * feat: make updatePasswordlessUser condition consistent with updateEmailOrPassword * test: add test to check that rsub is present in the front-token * feat: update unlinkAccount return type * feat: remove all mockCore files * feat: extend pwless testing, re-add missing changes * feat: checklist progress + updated/extended tests * test: extended account linking tests based on the checklist * feat: add some error codes to messages including contact support * feat: Account unlink endpoint for dashboard (#674) * unlink api for dashboard * run build * added removed tests back * minor typo fix * changed usage for recipeUserId * feat(account_linkig): optimize to have less core calls/update interfaces (#675) * feat: added tenantId to accountlinking callbacks * WIP * feat: export the RecipeUserId class * feat: add tenantId to listUsersByAccountInfo * feat: rename createdNewUser to createdNewRecipeUser in the node interfaces * feat: optimize account linking operations by reusing user objects * feat: further optimizations& renames * feat: self review fixes * chore: add changelog * feat: further optimization * feat: remove/reorder tenantId params in account linking * feat: remove unnecessary tenantId param from pwless updateUser * feat: add compatibility with older FDI + review comments * docs: expand with-typescript to use AccountLinking functions * chore: update changelog and version * feat: re-user verified info from user object in isSignInAllowed * test: add account linking-multitenancy interaction tests * fix: fix typo * fix: undo createNewRecipe rename on the CDI * test: extend dashboard tests w/ possible bug reports * feat: added an extra check for empty string when getting userId from querystring in dashboard APIs * feat: remove unnecessary code and update tests & types --------- Co-authored-by: Mihaly Lengyel <[email protected]> * test: test util improvements * docs: moved account-linking example app to auth-react * feat: update error codes * fix: emailExistsGET should check if the login method has the right email * feat: allow sign-in in more cases * feat: remove EMAIL_ALREADY_USED_IN_ANOTHER_ACCOUNT * feat: update types based on CDI changes * feat: ignore protected props in createNewSession* (#690) * feat: update return type of update user in pwless * feat: add separate error codes for sign in/up not allowed in EP * fix: make connection refused detection in querier a bit more general * feat: remove tenantId from isEmailChangeAllowed inputs * feat: make user (dis)association fns take recipeUserId instead of userId * test: update tests for new behaviour + some cleanup * fix: fix returning SIGN_UP_NOT_ALLOWED to the client * fix: update the error message for ERR_CODE_007 * feat: remove DISASSOCIATION_NOT_ALLOWED_ERROR * chore: update changelog * feat: update param name to match CDI * chore: bump dashboard version * fix: update types based on the CDI * test: update tests * test: update auth-react-server for tests * test: update test server to better handle in-memory tests * chore: extended changelog * test: update integration test server * test: add an extended test checking if protected props are ignored in createNewSession * fix: return FIELD_ERROR even if AL is on if there is a conflicting EP user in EP sign up * Apply suggestions from code review Co-authored-by: Rishabh Poddar <[email protected]> * docs: extended changelog & implemented review comments * docs: make migration guide more consistent * Update .github/PULL_REQUEST_TEMPLATE.md --------- Co-authored-by: Bhumil Sarvaiya <[email protected]> Co-authored-by: Rishabh Poddar <[email protected]> Co-authored-by: Nemi Shah <[email protected]> Co-authored-by: Iresh Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
SessionRelated issues
Test Plan
Modified existing tests
Documentation changes
Done separately, some updates required
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)lib/ts/version.tsfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettyrecipe/thirdparty/providers/configUtils.tsfile,createProviderfunction.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.add-ts-no-check.jsfile to include thatsomeFunc: function () {..}).