feat: Add BulkImport APIs and cron #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
suggested changes
Mar 20, 2024
src/main/java/io/supertokens/pluginInterface/bulkimport/sqlStorage/BulkImportSQLStorage.java
Outdated
Show resolved
Hide resolved
src/main/java/io/supertokens/pluginInterface/bulkimport/BulkImportStorage.java
Outdated
Show resolved
Hide resolved
sattvikc
requested changes
Mar 29, 2024
src/main/java/io/supertokens/pluginInterface/bulkimport/BulkImportStorage.java
Show resolved
Hide resolved
sattvikc
requested changes
Apr 17, 2024
sattvikc
requested changes
Apr 22, 2024
rishabhpoddar
suggested changes
May 5, 2024
Comment on lines
55
to
74
| // This method returns a JSON object string representation, excluding 'status', 'createdAt', and 'updatedAt'. | ||
| // It is used for inserting the user into the database or during testing. | ||
| public String toRawDataForDbStorage() { | ||
| JsonObject jsonObject = new Gson().fromJson(new Gson().toJson(this), JsonObject.class); | ||
| jsonObject.remove("status"); | ||
| jsonObject.remove("createdAt"); | ||
| jsonObject.remove("updatedAt"); | ||
| return jsonObject.toString(); | ||
| } | ||
|
|
||
| public static BulkImportUser fromRawDataFromDbStorage(String id, String rawData, BULK_IMPORT_USER_STATUS status, String primaryUserId, String errorMessage, long createdAt, long updatedAt) { | ||
| BulkImportUser user = new Gson().fromJson(rawData, BulkImportUser.class); | ||
| user.id = id; | ||
| user.status = status; | ||
| user.primaryUserId = primaryUserId; | ||
| user.errorMessage = errorMessage; | ||
| user.createdAt = createdAt; | ||
| user.updatedAt = updatedAt; | ||
| return user; | ||
| } |
There was a problem hiding this comment.
these two fucntions are very unclear. As a reader of this code, it makes no sense why they are there. Please add more detailed comment with examples.
There was a problem hiding this comment.
I have added comment to explain the purpose of these functions. That should help explain it.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
(A few sentences about this PR)
Related issues
Checklist for important updates
build.gradlegit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.