Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat! :upgrade postgresql to 13 in cicd plugin testing env #242

Merged
merged 12 commits into from
Jan 10, 2025

Conversation

tamassoltesz
Copy link
Contributor

Summary of change

This PR:

  • replaces the rishabhpoddar/supertokens_postgresql_plugin_test image with my own.
  • with this: upgrades the postgresql version used in the cicd plugin tests from 9.5 to 13.
  • includes the dockerfile in the repo from which my image was built.

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • pluginInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In build.gradle
  • Had installed and ran the pre-commit hook
  • If there are new dependencies that have been added in build.gradle, please make sure to add them
    in implementationDependencies.json.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the
      latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • When adding new recipes, ensure that its performance is being measured in the OneMillionUsersTest

Remaining TODOs for this PR

  • Item1
  • Item2

@tamassoltesz tamassoltesz marked this pull request as ready for review January 9, 2025 15:44
@sattvikc sattvikc merged commit d77cf3b into 7.3 Jan 10, 2025
1 of 6 checks passed
@sattvikc sattvikc deleted the test-cicd/upgrade-postgresql-to-13 branch January 10, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants