Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dashboard admin feature #442

Merged
merged 12 commits into from
Sep 12, 2023
Merged

feat: Add dashboard admin feature #442

merged 12 commits into from
Sep 12, 2023

Conversation

KShivendu
Copy link
Contributor

@KShivendu KShivendu commented Sep 8, 2023

Summary of change

Add dashboard admin feature

Related issues

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

@KShivendu
Copy link
Contributor Author

KShivendu commented Sep 8, 2023

I manually tested the dashboard by temporarily hardcoding email header and setting admins config in dashboard recipe. It blocked the non-admin users from doing non GET operations (except analytics and signout as expected)

Have asked @Chakravarthy7102 to cross check as suggested by @nkshah2

@@ -8,7 +8,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [unreleased]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.16.0 -> with the protected props thing for create new session.

@rishabhpoddar rishabhpoddar changed the base branch from 0.15 to 0.16 September 12, 2023 10:35
@rishabhpoddar rishabhpoddar merged commit 7bc490c into 0.16 Sep 12, 2023
5 of 7 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/dashboard-admins branch September 12, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants