Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dependency phonenumbers and twilio #534

Merged
merged 8 commits into from
Oct 17, 2024
Merged

fix: update dependency phonenumbers and twilio #534

merged 8 commits into from
Oct 17, 2024

Conversation

sattvikc
Copy link
Collaborator

@sattvikc sattvikc commented Oct 16, 2024

Summary of change

updates phonenumbers and twilio deps.

Related issues

Test Plan

Manually tested that it doesn't downgrade now.

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Item1
  • Item2

@sattvikc sattvikc self-assigned this Oct 16, 2024
@sattvikc sattvikc changed the title fix: dependency downgrade for phonenumbers and twilio fix: update dependency phonenumbers and twilio Oct 16, 2024
@sattvikc sattvikc merged commit abe6f5c into 0.24 Oct 17, 2024
3 of 4 checks passed
@sattvikc sattvikc deleted the deps-fix branch October 17, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant