update: makes url path normalization case sensitive #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namsnath
force-pushed
the
update/handle-case-sensitive-oidc-urls
branch
2 times, most recently
from
bfbb825 to
c46441f
Compare
namsnath
changed the base branch from
ci/github-actions/containerized-core/unit-tests
to
ci/github-actions/backend-sdk-testing
namsnath
force-pushed
the
ci/github-actions/backend-sdk-testing
branch
from
2ed4d05 to
4cf4abf
Compare
namsnath
force-pushed
the
update/handle-case-sensitive-oidc-urls
branch
from
c46441f to
d0b9962
Compare
namsnath
force-pushed
the
update/handle-case-sensitive-oidc-urls
branch
2 times, most recently
from
cd4711e to
01806a5
Compare
- Updates `normalise_url_path_or_throw_error` to be case sensitive - URL paths will not be converted to lower-case, and will be kept as-is. Co-authored-by: Pulkit Gaur <[email protected]>
namsnath
force-pushed
the
update/handle-case-sensitive-oidc-urls
branch
from
01806a5 to
b56dd6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
normalise_url_path_or_throw_errorto be case sensitiveRelated issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens_python/constants.pyfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)setup.pysupertokens_python/constants.pygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.supertokens_python/utils.pyfile to include that in theFRAMEWORKSvariablesyncio/asynciofunctions are consistent.tests/sessions/test_access_token_version.pyto account for any new claims that are optional or omitted by the coreRemaining TODOs for this PR