Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for webauthn #123

Open
wants to merge 21 commits into
base: 0.14
Choose a base branch
from
Open

feat: Support for webauthn #123

wants to merge 21 commits into from

Conversation

deepjyoti30-st
Copy link

@deepjyoti30-st deepjyoti30-st commented Dec 6, 2024

Summary of change

This PR adds webauthn support by routing calls to node SDK

Related issues

Test Plan

Tests will be written in react-auth repo.

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • webJsInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

Copy link

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size
lib/build/index.js 27.23 KB (+0.02% 🔺)
recipe/emailverification/index.js 27.65 KB (+0.01% 🔺)
recipe/emailpassword/index.js 27.6 KB (+0.01% 🔺)
recipe/thirdparty/index.js 28.39 KB (+0.01% 🔺)
recipe/session/index.js 24.37 KB (0%)
recipe/passwordless/index.js 28.66 KB (+0.01% 🔺)
recipe/userroles/index.js 24.64 KB (0%)
recipe/multitenancy/index.js 26.95 KB (+0.02% 🔺)
recipe/multifactorauth/index.js 27.05 KB (+0.01% 🔺)
recipe/totp/index.js 26.87 KB (+0.01% 🔺)
recipe/oauth2provider/index.js 27.4 KB (+0.01% 🔺)

@deepjyoti30-st deepjyoti30-st changed the title Support for webauthn feat: Support for webauthn Dec 6, 2024
@deepjyoti30-st deepjyoti30-st marked this pull request as ready for review December 12, 2024 08:32
@@ -171,3 +171,9 @@ export type User = {
};
}[];
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loginMethods and user should support webauthn also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants