Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvement #144

Open
wants to merge 4 commits into
base: update-xcresultparser
Choose a base branch
from

Conversation

mrandrewsmith
Copy link
Collaborator

What is done

  • Added functionality for logging proxying
  • Created tests for new functionality
  • Updated documentation

Examples

struct NodeKitLoggingProxy: LoggingProxy {
    func handle(session: LogSession) {
        Task {
	    let method = await session.method
	    let route = await session.route
	    await session.subscribe { logs in
	        ...
            }
	}
    }
}
let loggingProxy = NodeKitLoggingProxy()

await chainBuilder
    .set(loggingProxy: loggingProxy)
    .route(.get, .users)
    .build()
    .process()

@mrandrewsmith mrandrewsmith changed the base branch from master to update-xcresultparser December 25, 2024 13:45
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 32 lines in your changes missing coverage. Please review.

Project coverage is 92.43%. Comparing base (1aaa23c) to head (157c496).
Report is 1 commits behind head on update-xcresultparser.

Files with missing lines Patch % Lines
NodeKit/NodeKit/Chains/ChainBuilder.swift 39.62% 32 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           update-xcresultparser     #144      +/-   ##
=========================================================
+ Coverage                  92.23%   92.43%   +0.20%     
=========================================================
  Files                         85       85              
  Lines                       1326     1944     +618     
=========================================================
+ Hits                        1223     1797     +574     
- Misses                       103      147      +44     
Flag Coverage Δ
tests 92.43% <84.61%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants