-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added a service for displaying snacks #114
Conversation
final BuildContext context; | ||
|
||
/// Create an instance [DefaultSnackController]. | ||
const DefaultSnackController.from(this.context); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is not a good idea to hold BuildContext
as a field in the class. Can we add BuildContext
as a parameter to the showSnack
method?
lib/features/snack_queue/controllers/default_snack_controller.dart
Outdated
Show resolved
Hide resolved
lib/features/snack_queue/controllers/default_snack_controller.dart
Outdated
Show resolved
Hide resolved
lib/features/snack_queue/domain/entities/snack_message_type.dart
Outdated
Show resolved
Hide resolved
…ability to configure animations for snack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, provide a video on how it works now.
I added a screencast to the description of the PR |
Checklist
A service has been written that will help you use flutter_easy_dialogs to display snacks "out of the box".
2024-04-11.14.47.33.mov
screencast with animation:
2024-05-07.17.05.07.mov
top padding:
new padding:
fix
,close
,resolve
etc. if necessary)New Features
What new capabilities does this PR add?
What docs changes are needed to explain this?