Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added a service for displaying snacks #114

Merged
merged 15 commits into from
May 13, 2024

Conversation

internetova
Copy link
Contributor

@internetova internetova commented Apr 11, 2024

Checklist

A service has been written that will help you use flutter_easy_dialogs to display snacks "out of the box".

2024-04-11.14.47.33.mov

screencast with animation:

2024-05-07.17.05.07.mov

top padding:

Снимок экрана 2024-05-07 в 17 50 52

new padding:

Снимок экрана 2024-05-08 в 13 10 35
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Is there an existing issue for this PR?
    • link issue here (use keywords like fix, close, resolve etc. if necessary)
  • Have the files been linted and formatted?
  • Have the docs been updated to match the changes in the PR?
  • Have the tests been updated to match the changes in the PR?
  • Attached videos/screenshots demonstrating the fix/feature.
  • Have you run the tests locally to confirm they pass?

New Features

What new capabilities does this PR add?

What docs changes are needed to explain this?

@internetova internetova self-assigned this Apr 11, 2024
@internetova internetova added the enhancement New feature or request label Apr 11, 2024
Copy link

Link to Pyrus task

final BuildContext context;

/// Create an instance [DefaultSnackController].
const DefaultSnackController.from(this.context);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not a good idea to hold BuildContext as a field in the class. Can we add BuildContext as a parameter to the showSnack method?

@internetova internetova added the wip Works in progress label Apr 17, 2024
@plasticfiresam plasticfiresam self-requested a review April 23, 2024 00:19
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0.75188% with 132 lines in your changes are missing coverage. Please review.

Project coverage is 23.16%. Comparing base (339c48c) to head (46893e3).
Report is 17 commits behind head on main.

Files Patch % Lines
...tures/snack_queue/presentation/snack_queue_wm.dart 0.00% 63 Missing ⚠️
...k_queue/presentation/default_snack_controller.dart 3.84% 25 Missing ⚠️
...tures/debug/presentation/ui_kit/ui_kit_screen.dart 0.00% 18 Missing ⚠️
.../features/debug/presentation/ui_kit/ui_kit_wm.dart 0.00% 8 Missing ⚠️
...s/snack_queue/presentation/snack_queue_widget.dart 0.00% 5 Missing ⚠️
...snack_queue/presentation/snack_queue_provider.dart 0.00% 4 Missing ⚠️
...atures/snack_queue/presentation/top_snack_bar.dart 0.00% 4 Missing ⚠️
lib/l10n/app_localizations_en.g.dart 0.00% 2 Missing ⚠️
lib/l10n/app_localizations_ru.g.dart 0.00% 2 Missing ⚠️
...es/snack_queue/presentation/snack_queue_model.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   26.39%   23.16%   -3.23%     
==========================================
  Files          55       61       +6     
  Lines         917     1049     +132     
==========================================
+ Hits          242      243       +1     
- Misses        675      806     +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dzmitry-struk-surf dzmitry-struk-surf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, provide a video on how it works now.

@DmitrDomrachev
Copy link
Contributor

Please, provide a video on how it works now.

I added a screencast to the description of the PR

@DmitrDomrachev DmitrDomrachev removed the wip Works in progress label May 7, 2024
@dzmitry-struk-surf dzmitry-struk-surf merged commit caa77a1 into main May 13, 2024
5 checks passed
@dzmitry-struk-surf dzmitry-struk-surf deleted the SNP-1241_Default_snack_controller branch May 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants