Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Permission handler #117

Merged
merged 15 commits into from
May 13, 2024
Merged

Conversation

internetova
Copy link
Contributor

Checklist

  • Add Permission handler
  • Add example
2024-04-12.18.09.20.mov
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Is there an existing issue for this PR?
    • link issue here (use keywords like fix, close, resolve etc. if necessary)
  • Have the files been linted and formatted?
  • Have the docs been updated to match the changes in the PR?
  • Have the tests been updated to match the changes in the PR?
  • Attached videos/screenshots demonstrating the fix/feature.
  • Have you run the tests locally to confirm they pass?

New Features

What new capabilities does this PR add?

What docs changes are needed to explain this?

@internetova internetova changed the title feat(SNP-1239): Permission handler feat: Permission handler Apr 12, 2024
Copy link

Link to Pyrus task

@internetova internetova requested a review from ekinsdrow April 12, 2024 15:13
@internetova internetova self-assigned this Apr 12, 2024
@internetova internetova added the enhancement New feature or request label Apr 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.39%. Comparing base (339c48c) to head (b510604).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   26.39%   26.39%           
=======================================
  Files          55       55           
  Lines         917      917           
=======================================
  Hits          242      242           
  Misses        675      675           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dzmitry-struk-surf dzmitry-struk-surf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general: do we need this functionality for all of our projects? I mean notifications and location permissions. It will be not really convenient take away them from our projects when not needed.
I think we do no need this functionality in the template, it can be like in knowledge base or whatever else but not in the template.

lib/features/app/di/app_scope.dart Outdated Show resolved Hide resolved
lib/features/debug/presentation/ui_kit/ui_kit_model.dart Outdated Show resolved Hide resolved
@plasticfiresam plasticfiresam self-requested a review April 23, 2024 00:19
@plasticfiresam
Copy link

In general: do we need this functionality for all of our projects?

We can use the same package to access the device file system/gallery/camera etc. This tends to be more common and adding the package to the template becomes more useful

Copy link
Contributor

@dzmitry-struk-surf dzmitry-struk-surf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove all code from this pr, and leave a single md file as a change.

docs/permission_handler.md Show resolved Hide resolved
docs/permission_handler.md Outdated Show resolved Hide resolved
docs/permission_handler.md Outdated Show resolved Hide resolved
@DmitrDomrachev DmitrDomrachev requested a review from ekinsdrow May 7, 2024 14:53
pubspec.yaml Outdated Show resolved Hide resolved
@dzmitry-struk-surf dzmitry-struk-surf self-requested a review May 13, 2024 14:44
@dzmitry-struk-surf dzmitry-struk-surf merged commit 61946ed into main May 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants