-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Permission handler #117
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
=======================================
Coverage 26.39% 26.39%
=======================================
Files 55 55
Lines 917 917
=======================================
Hits 242 242
Misses 675 675 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general: do we need this functionality for all of our projects? I mean notifications and location permissions. It will be not really convenient take away them from our projects when not needed.
I think we do no need this functionality in the template, it can be like in knowledge base or whatever else but not in the template.
We can use the same package to access the device file system/gallery/camera etc. This tends to be more common and adding the package to the template becomes more useful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should remove all code from this pr, and leave a single md file as a change.
Checklist
2024-04-12.18.09.20.mov
fix
,close
,resolve
etc. if necessary)New Features
What new capabilities does this PR add?
What docs changes are needed to explain this?