Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SNP-1246): App Links Implementation #118

Merged
merged 1 commit into from
May 13, 2024
Merged

feat(SNP-1246): App Links Implementation #118

merged 1 commit into from
May 13, 2024

Conversation

danyaao
Copy link
Contributor

@danyaao danyaao commented Apr 19, 2024 •
edited
Loading

Changes:

  • add deeplink feature
  • implement app_links
  • add simple deeplink handling

Demo:

video_2024-04-24_12-11-15.mp4

@danyaao danyaao requested a review from ekinsdrow April 19, 2024 13:50
@danyaao danyaao self-assigned this Apr 19, 2024
@github-actions GitHub Actions
Copy link

Link to Pyrus task

@danyaao danyaao requested a review from plasticfiresam April 22, 2024 11:12
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.39%. Comparing base (339c48c) to head (8e87659).
Report is 17 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   26.39%   26.39%           
=======================================
  Files          55       55           
  Lines         917      917           
=======================================
  Hits          242      242           
  Misses        675      675

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dzmitry-struk-surf dzmitry-struk-surf self-requested a review May 6, 2024 12:35
dzmitry-struk-surf
dzmitry-struk-surf requested changes May 6, 2024
View reviewed changes
Copy link
Contributor

@dzmitry-struk-surf dzmitry-struk-surf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove all code from this pr, and leave a single md file as a change.

docs/deeplinking.md Outdated Show resolved Hide resolved
docs/deeplinking.md Outdated Show resolved Hide resolved
docs/deeplinking.md Show resolved Hide resolved
@danyaao danyaao requested a review from dzmitry-struk-surf May 7, 2024 05:23
ekinsdrow
ekinsdrow reviewed May 7, 2024
View reviewed changes
lib/features/app/app_flow.dart Outdated Show resolved Hide resolved
lib/features/deeplink/di/deeplink_scope.dart Outdated Show resolved Hide resolved
@danyaao danyaao force-pushed the SNP-1246-app-links-implementation branch from 634ae80 to 8e87659 Compare May 8, 2024 09:50
@dzmitry-struk-surf dzmitry-struk-surf merged commit f6afea0 into main May 13, 2024
5 checks passed
@dzmitry-struk-surf dzmitry-struk-surf deleted the SNP-1246-app-links-implementation branch May 13, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekinsdrow ekinsdrow ekinsdrow approved these changes

@dzmitry-struk-surf dzmitry-struk-surf dzmitry-struk-surf approved these changes

@plasticfiresam plasticfiresam Awaiting requested review from plasticfiresam

Assignees

@danyaao danyaao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danyaao @codecov-commenter @ekinsdrow @dzmitry-struk-surf