Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SNP-1717): Add tailor - ThemeExtension generator #121

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

Sadhorsephile
Copy link
Contributor

Changes

  • Add tailor
  • Remove color palette

@Sadhorsephile Sadhorsephile added the enhancement New feature or request label Jul 17, 2024
@Sadhorsephile Sadhorsephile requested a review from mpkander July 17, 2024 13:27
@Sadhorsephile Sadhorsephile self-assigned this Jul 17, 2024
Copy link

Link to Pyrus task

Copy link
Contributor

@mpkander mpkander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for successful CI build

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 24.97%. Comparing base (339c48c) to head (6750952).
Report is 21 commits behind head on main.

Files Patch % Lines
lib/common/mixin/theme_wm_mixin.dart 0.00% 2 Missing ⚠️
...tures/debug/presentation/ui_kit/ui_kit_screen.dart 0.00% 2 Missing ⚠️
...k_queue/presentation/default_snack_controller.dart 0.00% 2 Missing ⚠️
lib/uikit/colors/app_color_scheme.dart 80.00% 1 Missing ⚠️
lib/uikit/text/app_text_scheme.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   26.39%   24.97%   -1.42%     
==========================================
  Files          55       61       +6     
  Lines         917      973      +56     
==========================================
+ Hits          242      243       +1     
- Misses        675      730      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitrDomrachev DmitrDomrachev requested a review from mpkander July 22, 2024 09:27
@DmitrDomrachev
Copy link
Contributor

We also need to update the AppThemeData class according to the migration guide

https://docs.flutter.dev/release/breaking-changes/new-color-scheme-roles#migration-guide

@DmitrDomrachev
Copy link
Contributor

DmitrDomrachev commented Jul 22, 2024

Waiting for successful CI build

cicd script was successfully executed

@mpkander mpkander merged commit e561d02 into main Jul 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants