Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added visible region in change camera position callback for custom clusterization #16

Merged
merged 10 commits into from
Mar 18, 2024

Conversation

samirakhmedov
Copy link
Contributor

@samirakhmedov samirakhmedov commented Feb 15, 2024

Dependence on other Pull Requests (optional)

#14

Background (optional)

This addition to functionality has to be added for custom clusterization to be possible, so then we can add it to our project

Changes

Added visible region to onCameraPositionChanged callback, so we always have up-to-date

Also implemented the example clusterization (has some pros when comparing with out-of-the-box cluster implementation)

Screen.Recording.2024-02-15.at.22.36.03.mov

Checklist for self-check

  • Commits and PRs have been filed according to the rules on the project.
  • The author is marked as an assigne and assigned mandatory reviewers.
  • Required labels marked
  • Specified related tasks and/or related PRs.
  • Specified Changes.
  • Attached videos/screenshots demonstrating the fix/feature.
  • All unspecified fields in the PR description deleted.
  • New code covered by tests.

Checklist for reviewers

  • CI passed successfully (with a green check mark).
  • PR is atomic, by volume no more than 400 (+-) corrected lines (not including codogen).

Design:

  • System design corresponds to the agreements on structure and architecture on the project.
  • The code is decomposed into necessary and sufficient components.

Functionality:

  • The code solves the problem.
  • Any changes to the user interface are reasonable and look good.

Complexity:

  • The code is clear, easy to read, functions are small, no more than 50 lines.
  • The logic is not overcomplicated, there is no overengineering (no code sections that may be needed in the future, but no one knows about it).

Tests:

  • Updated or added tests for mandatory components.
  • The tests are correct, helpful, and well designed/developed.

Naming:

  • The naming of variables, methods, classes and other components is understandable.

Comments:

  • The comments are understandable and helpful.

Documentation:

  • All labels are correct
  • Technical documentation updated (after approval, updates last reviewer).

@samirakhmedov samirakhmedov added the enhancement New feature or request label Feb 15, 2024
@samirakhmedov samirakhmedov self-assigned this Feb 15, 2024
Base automatically changed from change/more_presentable_example_project to main February 16, 2024 12:21
@samirakhmedov
Copy link
Contributor Author

@maxim-sysoev @internetova could you please review this PR and format it (i dont know what your format settings are), i really need this functionality for one of our projects

@dzmitry-struk-surf
Copy link

@internetova @Sadhorsephile @maxim-sysoev what stops you from reviewing the pr, are there any problems or blockers? If so, leave some feedback in comments, please.

@dzmitry-struk-surf dzmitry-struk-surf requested review from ekinsdrow and removed request for maxim-sysoev and internetova March 14, 2024 12:56
@ekinsdrow ekinsdrow merged commit b263b87 into main Mar 18, 2024
7 checks passed
@ekinsdrow ekinsdrow deleted the change/custom-clusterization-issue branch March 18, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants