-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added visible region in change camera position callback for custom clusterization #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stom clusterization
Base automatically changed from
change/more_presentable_example_project
to
main
February 16, 2024 12:21
@maxim-sysoev @internetova could you please review this PR and format it (i dont know what your format settings are), i really need this functionality for one of our projects |
example/lib/presentation/state/custom_clusterization_map_strategy.dart
Outdated
Show resolved
Hide resolved
example/lib/presentation/state/custom_clusterization_map_strategy.dart
Outdated
Show resolved
Hide resolved
example/lib/presentation/state/custom_clusterization_map_strategy.dart
Outdated
Show resolved
Hide resolved
example/lib/presentation/state/custom_clusterization_map_strategy.dart
Outdated
Show resolved
Hide resolved
example/lib/presentation/state/custom_clusterization_map_strategy.dart
Outdated
Show resolved
Hide resolved
Evgenia-bit
approved these changes
Mar 5, 2024
@internetova @Sadhorsephile @maxim-sysoev what stops you from reviewing the pr, are there any problems or blockers? If so, leave some feedback in comments, please. |
example/lib/presentation/state/custom_clusterization_map_strategy.dart
Outdated
Show resolved
Hide resolved
Sadhorsephile
approved these changes
Mar 13, 2024
dzmitry-struk-surf
requested review from
ekinsdrow
and removed request for
maxim-sysoev and
internetova
March 14, 2024 12:56
ekinsdrow
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependence on other Pull Requests (optional)
#14
Background (optional)
This addition to functionality has to be added for custom clusterization to be possible, so then we can add it to our project
Changes
Added visible region to onCameraPositionChanged callback, so we always have up-to-date
Also implemented the example clusterization (has some pros when comparing with out-of-the-box cluster implementation)
Screen.Recording.2024-02-15.at.22.36.03.mov
Checklist for self-check
Checklist for reviewers
Design:
Functionality:
Complexity:
Tests:
Naming:
Comments:
Documentation: