Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Editor scrolling fix #7949

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

blancoberg
Copy link
Contributor

It turns out that scrollBy() sucks, as it scrolls way past its maximum limit. So went with another approach

* Makes it possible to mousewheel scroll and select text at the same time.
* Shift + mousewheel scrolls sideways
It turns out that scrollBy() sucks. It scrolls way past its maximum scroll value.
Added enum for clearity (hopefully)
Null check on scrollbars
@mkruselj mkruselj changed the title Code editor scroll2 Code Editor scrolling fix Jan 6, 2025
@mkruselj mkruselj merged commit e96a977 into surge-synthesizer:main Jan 6, 2025
13 checks passed
@blancoberg blancoberg deleted the codeeditor_scroll2 branch January 13, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants