Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parentheses in GRPC.Stub to avoid warnings during compilation in … #18

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

davidwebster48
Copy link

It resolves this warning reported during compilation:

warning: using map.field notation (without parentheses) to invoke function Rpc.LandingPagesManager.V1.RPCService.Service.__rpc_calls__() is deprecated, you must add parentheses instead: remote.function()
  lib/rpc/landing_pages_manager/v1/landing_pages_manager_service.pb.ex:56: (module)
  (elixir 1.17.3) src/elixir_compiler.erl:77: :elixir_compiler.dispatch/4
  (elixir 1.17.3) src/elixir_compiler.erl:52: :elixir_compiler.compile/4
  (elixir 1.17.3) src/elixir_module.erl:427: :elixir_module.eval_form/7
  (elixir 1.17.3) src/elixir_module.erl:129: :elixir_module.compile/7

This PR applies the same fix as #16 but in a different module.

@glizda glizda merged commit 73d259a into master Nov 5, 2024
8 checks passed
@glizda glizda deleted the fix-warning-in-elixir-1-17-2 branch November 5, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants