-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup priv package #1
Conversation
b4f45b7
to
103931e
Compare
Add resource version parameter for kubernates strategy.
a2a3127
to
76dba55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change seems ok for me. I dont fully understand why you use resourceVersion
, what is the reasoning behind that change.
How does this change will reduce the API calls to kubernetes 🤔 ?
@@ -1,7 +1,7 @@ | |||
defmodule Cluster.Mixfile do | |||
use Mix.Project | |||
|
|||
@version "3.4.1" | |||
@version "4.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Is this really a major change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emancu it's just our fork, not origin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why not doing changes taht can be contributed back to the original project?
Summary of changes
I'll review the commits, so I mostly want to understand the "why" rather than the "what"
Checklist