updating the error handling (#41)

* adding glue module to enable error handling (#27) * added batching runner (#28) * Kings college london integration (#30) * adding build using binary downloads (#8) * adding build using binary downloads * sorting out the build.rs * updating build.rs for surrealml package * prepping version for release * now has target tracking (#10) * adding check in build.rs for docs.rs * removing build.rs for main surrealml to ensure that libraries using the core do not need to do anything in their build.rs * adding machine learning pipelines for bioengineering projects at Kings College London * Remove integrated_training_runner/run_env/ from tracking * adding machine learning pipelines for bioengineering projects at Kings College London * Update FFmpeg data access module and README (#29) * adding run_env to the gitignore --------- Co-authored-by: Yang Li <[email protected]> * bumping the version * updating the README and module * updating the surrealml-core deployment workflow * updating the surrealml-core deployment workflow * updating cargo * Error modules (#36) * Develop (#35) * adding glue module to enable error handling (#27) * added batching runner (#28) * Kings college london integration (#30) * adding build using binary downloads (#8) * adding build using binary downloads * sorting out the build.rs * updating build.rs for surrealml package * prepping version for release * now has target tracking (#10) * adding check in build.rs for docs.rs * removing build.rs for main surrealml to ensure that libraries using the core do not need to do anything in their build.rs * adding machine learning pipelines for bioengineering projects at Kings College London * Remove integrated_training_runner/run_env/ from tracking * adding machine learning pipelines for bioengineering projects at Kings College London * Update FFmpeg data access module and README (#29) * adding run_env to the gitignore --------- Co-authored-by: Yang Li <[email protected]> * bumping the version * updating the README and module * updating the surrealml-core deployment workflow * updating the surrealml-core deployment workflow * updating cargo --------- Co-authored-by: Sam Hillman <[email protected]> Co-authored-by: Yang Li <[email protected]> * merging error modules into the core * merging error modules into the core * merging error modules into the core --------- Co-authored-by: Sam Hillman <[email protected]> Co-authored-by: Yang Li <[email protected]> * Index overflow (#40) * adding buffer out of index check * adding buffer out of index check --------- Co-authored-by: Sam Hillman <[email protected]> Co-authored-by: Yang Li <[email protected]>
surrealdb · Mar 25, 2024 · bc6bc68 · bc6bc68
1 parent 888e0f1
commit bc6bc68
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/modules/core/Cargo.toml b/modules/core/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "surrealml-core"
-version = "0.1.0"
+version = "0.1.1"
 edition = "2021"
 build = "./build.rs"
 description = "The core machine learning library for SurrealML that enables SurrealDB to store and load ML models"

diff --git a/modules/core/src/storage/surml_file.rs b/modules/core/src/storage/surml_file.rs
@@ -80,14 +80,24 @@ impl SurMlFile {
         buffer.copy_from_slice(&bytes[0..4]);
         let integer_value = u32::from_be_bytes(buffer);
 
+        // check to see if there is enough bytes to read
+        if bytes.len() < (4 + integer_value as usize) {
+            return Err(
+                SurrealError::new(
+                    "Not enough bytes to read for header, maybe the file format is not correct".to_string(),
+                    SurrealErrorStatus::BadRequest
+                )
+            );
+        }
+
         // Read the next integer_value bytes for the header
         header_bytes.extend_from_slice(&bytes[4..(4 + integer_value as usize)]);
 
         // Read the remaining bytes for the model
         model_bytes.extend_from_slice(&bytes[(4 + integer_value as usize)..]);
 
         // construct the header and C model from the bytes
-        let header = Header::from_bytes(header_bytes).unwrap();
+        let header = Header::from_bytes(header_bytes)?;
         let model = model_bytes;
         Ok(Self {
             header,