patch bug - show_if on reactive questions

surveydown-dev · Sep 24, 2024 · 295d865 · 295d865
1 parent f2f8004
commit 295d865
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/R/config.R b/R/config.R
@@ -110,12 +110,10 @@ extract_html_pages <- function(
                 if (!is.null(show_if)) {
                     if (question_id %in% show_if$targets) {
                         current_style <- xml2::xml_attr(container, "style")
-                        current_style <- if (is.na(current_style)) "" else current_style
-                        new_style <- paste(current_style, "display: none;", sep = " ")
+                        new_style <- gsub("display:\\s*block;", "display: none;", current_style, ignore.case = TRUE)
                         xml2::xml_attr(container, "style") <- new_style
                     }
                 }
-
                 question_containers[[i]] <- container
             }
 

diff --git a/R/ui.R b/R/ui.R
@@ -800,7 +800,7 @@ sd_output <- function(id, type = NULL, display = "inline", wrapper = NULL, ...)
         return(shiny::div(
             id = paste0("placeholder-", id),
             `data-question-id` = id,
-            class = "question-container reactive-question-placeholder",
+            class = "question-container",
             shiny::uiOutput(id)
         ))
     }