Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/support ruby3.2 faraday2 #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Features/support ruby3.2 faraday2 #1

wants to merge 7 commits into from

Conversation

nicolapagiaro
Copy link
Collaborator

No description provided.

@nicolapagiaro nicolapagiaro requested a review from cecilian May 31, 2023 08:42
@nicolapagiaro nicolapagiaro self-assigned this May 31, 2023
@cecilian
Copy link
Collaborator

cecilian commented Jun 1, 2023

Ma quindi in pratica è bastato aggiornare la versione e spacchettare le dipendenze e funziona lo stesso come prima?

@cecilian
Copy link
Collaborator

cecilian commented Jun 1, 2023

Toglierei byebug però, non mi pare corretto averlo come dipendenza, uno se ne ha bisogno se lo aggiunge no?

@nicolapagiaro
Copy link
Collaborator Author

no giusto byebug va tolto, l'avevo messo solo per del debugging e si è bastato fare il bump della dipendenza ed includere gli adapter in specifico perché non lì ha più inglobati nella gemma principale e fine, alla fine le API di faraday non son cambiate così tanto

cecilian
cecilian reviewed Jun 15, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
ipinfo.gemspec Outdated Show resolved Hide resolved
lib/ipinfo/adapter.rb Outdated Show resolved Hide resolved
test/test_helper.rb Outdated Show resolved Hide resolved
@nicolapagiaro nicolapagiaro force-pushed the features/support_ruby3_faraday2 branch from ed5d970 to 77e0222 Compare July 17, 2023 15:20
@nicolapagiaro nicolapagiaro requested a review from cecilian July 17, 2023 15:20
@nicolapagiaro nicolapagiaro force-pushed the features/support_ruby3_faraday2 branch 2 times, most recently from 5014dd6 to 5543ffb Compare July 17, 2023 15:24
@nicolapagiaro nicolapagiaro force-pushed the features/support_ruby3_faraday2 branch from 5543ffb to 647141c Compare September 20, 2023 07:34
@nicolapagiaro nicolapagiaro force-pushed the features/support_ruby3_faraday2 branch 2 times, most recently from 41934d4 to b74e7af Compare September 20, 2023 07:48
@nicolapagiaro nicolapagiaro force-pushed the features/support_ruby3_faraday2 branch 3 times, most recently from d880710 to a9bed46 Compare September 20, 2023 08:20
@nicolapagiaro nicolapagiaro force-pushed the features/support_ruby3_faraday2 branch from a9bed46 to b519414 Compare September 20, 2023 08:24
@nicolapagiaro nicolapagiaro changed the title Features/support ruby3 faraday2 Features/support ruby3.2 faraday2 Sep 20, 2023
@obroshnij
Copy link
Collaborator

@cecilian I think I have fixed the tests in this PR but unfortunately I can not push to this repository. Can you please add more permissions for myself?

@obroshnij
Copy link
Collaborator

@cecilian this build is also green now

@obroshnij
Copy link
Collaborator

@nicolapagiaro added PR with your changes to the original repo here ipinfo#44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecilian cecilian Awaiting requested review from cecilian

Assignees

@nicolapagiaro nicolapagiaro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolapagiaro @cecilian @obroshnij