Add numericGroupSeparator as a serializable property in inputmask plugin #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dmitrykurmanov, I hope you are doing well ! Did you have time to look at this small PR, it would be useful for us if this fix was merged ! Thanks in advance |
andrewtelnov
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to customize the
numericGroupSeparatoroptions in the inputmask plugin. Therefore when using adecimalorcurrencymask, we are forced to use,as separator (e.g.123,456.00).The changes in this PR allows users to override the separator in their survey config JSON, by adding
numericGroupSeparatoras a serializable property like it is already the case for other properties such assuffixornumericDigits