Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom editors in new theme #6136

Merged
merged 11 commits into from
Nov 28, 2024
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
width: var(--ctr-list-item-color-swatch-width, calcSize(4));
height: var(--ctr-list-item-color-swatch-height, calcSize(3));
box-sizing: border-box;
border: 1px solid $border-inside;
border: 1px solid var(--ctr-list-item-color-swatch-border-color, $border-inside);
margin-left: var(--ctr-editor-color-swatch-margin-left, calcSize(1.5));

.sv-svg-icon {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
border-radius: var(--ctr-editor-button-corner-radius);
background: var(--ctr-editor-button-background-color-hovered, $background-dim);
}
.spg-dropdown_chevron-button-svg use {
fill: var(--ctr-editor-button-icon-color, $foreground-light);
}
}
.spg-dropdown_chevron-button-svg {
width: var(--ctr-editor-button-icon-width, calcSize(3));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ input.spg-input:read-only::placeholder {
position: relative;
box-sizing: border-box;
appearance: none;
background: var(--ctr-editor-background-color, $background);
background: transparent;
border: none;
outline: none;
border-radius: var(--ctr-editor-button-corner-radius);
Expand Down Expand Up @@ -82,7 +82,7 @@ input.spg-input:read-only::placeholder {
.spg-input__edit-button--disabled,
.spg-input__edit-button:disabled {
opacity: var(--ctr-editor-button-icon-opacity-disabled, 0.25);
background: var(--ctr-editor-background-color-disabled, $background);
background: transparent;

svg {
fill: var(--ctr-editor-button-icon-color-disabled, $foreground-dim-light);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@
}

.spg-question__header--location--left {
width: auto;
width: max-content;
box-sizing: border-box;
max-width: 50%;
flex: 1;
flex: 0 0;
display: flex;
align-items: center;

Expand All @@ -106,6 +106,12 @@
border-right: 1px solid $border;
display: inline-block;
color: var(--ctr-editor-label-color, $foreground-dim-light);
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
.sv-string-viewer {
white-space: nowrap;
}
}
}

Expand Down Expand Up @@ -133,10 +139,6 @@
flex-grow: 1;
min-width: calcSize(25.5);

.spg-question__header--location--left {
min-width: calcSize(8);
}

input {
min-width: calc(max(17 * #{$base-unit}, 100%));
width: 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
}
}

.spg-question__header--location--left {
min-width: auto;
}

& > div {
flex-grow: 1;
flex-shrink: 1;
Expand All @@ -58,20 +54,6 @@
overflow: hidden;
}

.spg-question__header--location--left {
width: max-content;
flex: 0 0;

.spg-question__title {
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;

.sv-string-viewer {
white-space: nowrap;
}
}
}

//2 level nested
.spg-panel-by-page,
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified visualRegressionTests/tests/designer/etalons/bindings-editor.png