The Table of Content ignores the survey.validationEnabled = false opt…

…ion fix #9363
surveyjs · Jan 29, 2025 · bd999e8 · bd999e8
1 parent 2e73181
commit bd999e8
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 1 deletion.
diff --git a/packages/survey-core/src/survey.ts b/packages/survey-core/src/survey.ts
@@ -3575,6 +3575,7 @@ export class SurveyModel extends SurveyElementCore
   }
   private performValidationOnPageChanging(page: PageModel): boolean {
     if (this.isDesignMode) return false;
+    if(this.canGoTroughValidation()) return true;
     const index = this.visiblePages.indexOf(page);
     if (index < 0 || index >= this.visiblePageCount) return false;
     if (index === this.currentPageNo) return false;
@@ -4112,7 +4113,7 @@ export class SurveyModel extends SurveyElementCore
     return true;
   }
   private hasErrorsOnNavigate(doComplete: boolean): boolean {
-    if (!this.isEditMode || this.ignoreValidation) return false;
+    if (this.canGoTroughValidation()) return false;
     const skipValidation = doComplete && this.validationAllowComplete || !doComplete && this.validationAllowSwitchPages;
     const func = (hasErrors: boolean) => {
       if (!hasErrors || skipValidation) {
@@ -4125,6 +4126,7 @@ export class SurveyModel extends SurveyElementCore
     }
     return this.validateCurrentPage(func) !== true && !skipValidation;
   }
+  private canGoTroughValidation(): boolean { return !this.isEditMode || !this.validationEnabled; }
   private asyncValidationQuesitons: Array<Question>;
   private checkForAsyncQuestionValidation(
     questions: Array<Question>,

diff --git a/packages/survey-core/tests/surveyTOCTests.ts b/packages/survey-core/tests/surveyTOCTests.ts
@@ -703,6 +703,47 @@ QUnit.test("survey.tryNavigateToPage & survey.onValidatedErrorsOnCurrentPage, Bu
   assert.equal(survey.tryNavigateToPage(survey.pages[0]), true, "try #8");
   assert.deepEqual(logs, ["page1", "page1", "page1", "page2", "page2"], "logs #8");
 });
+QUnit.test("survey.tryNavigateToPage & survey.validationEnabled = false, Bug#9363", function (assert) {
+  let json: any = {
+    "pages": [
+      {
+        "name": "page1",
+        "elements": [
+          {
+            "type": "text",
+            "name": "question1",
+            "isRequired": true
+          }
+        ]
+      },
+      {
+        "name": "page2",
+        "elements": [
+          {
+            "type": "text",
+            "name": "question2",
+            "isRequired": true
+          }
+        ]
+      },
+      {
+        "name": "page3",
+        "elements": [
+          {
+            "type": "text",
+            "name": "question3",
+            "isRequired": true
+          }
+        ]
+      }
+    ]
+  };
+  const survey = new SurveyModel(json);
+  const logs = new Array<string>();
+  assert.equal(survey.tryNavigateToPage(survey.pages[1]), false, "try #1");
+  survey.validationEnabled = false;
+  assert.equal(survey.tryNavigateToPage(survey.pages[1]), true, "try #2");
+});
 QUnit.test("The survey.onServerValidateQuestions function is not invoked when a user navigates between pages using the progress bar #9332", function (assert) {
   const survey = new SurveyModel({
     "pages": [