Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test scrolling fix #38

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Test scrolling fix #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 19 additions & 32 deletions src/pages/Discover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ export function Discover() {
genres.forEach((genre) => fetchMoviesForGenre(genre.id));
}, [genres]);

// Update the scrollCarousel function to use the new ref map
function scrollCarousel(categorySlug: string, direction: string) {
const carousel = carouselRefs.current[categorySlug];
if (carousel) {
Expand All @@ -237,22 +236,7 @@ export function Discover() {
const scrollAmount = movieWidth * visibleMovies * 0.69; // Silly number :3

if (direction === "left") {
if (carousel.scrollLeft <= 5) {
carousel.scrollBy({
left: carousel.scrollWidth,
behavior: "smooth",
}); // Scroll to the end
} else {
carousel.scrollBy({ left: -scrollAmount, behavior: "smooth" });
}
} else if (
carousel.scrollLeft + carousel.offsetWidth + 5 >=
carousel.scrollWidth
) {
carousel.scrollBy({
left: -carousel.scrollWidth,
behavior: "smooth",
}); // Scroll to the beginning
carousel.scrollBy({ left: -scrollAmount, behavior: "smooth" });
} else {
carousel.scrollBy({ left: scrollAmount, behavior: "smooth" });
}
Expand Down Expand Up @@ -284,42 +268,39 @@ export function Discover() {
}
}, [movieWidth]);

const browser = !!window.chrome; // detect chromium browser
let isScrolling = false;

function handleWheel(e: React.WheelEvent, categorySlug: string) {
if (isScrolling) {
return;
}

isScrolling = true;

const carousel = carouselRefs.current[categorySlug];
if (carousel && !e.deltaX) {
if (carousel) {
const movieElements = carousel.getElementsByTagName("a");
if (movieElements.length > 0) {
const posterWidth = movieElements[0].offsetWidth;
const visibleMovies = Math.floor(carousel.offsetWidth / posterWidth);
const scrollAmount = posterWidth * visibleMovies * 0.62;
if (e.deltaY < 5) {
carousel.scrollBy({ left: -scrollAmount, behavior: "smooth" });
scrollCarousel(categorySlug, "left");
} else {
carousel.scrollBy({ left: scrollAmount, behavior: "smooth" });
scrollCarousel(categorySlug, "right");
}
}
}

setTimeout(() => {
if (browser) {
setTimeout(() => {
isScrolling = false;
}, 345); // disable scrolling after 345 milliseconds for chromium-based browsers
} else {
// immediately reset isScrolling for non-chromium browsers
isScrolling = false;
}, 345); // Disable scrolling every 3 milliseconds after interaction (only for mouse wheel doe)
}
}

const [isHovered, setIsHovered] = useState(false);

useEffect(() => {
if (!isHovered) {
document.body.style.overflow = "auto";
}
}, [isHovered]);

const handleMouseEnter = () => {
document.body.style.overflow = "hidden";
setIsHovered(true);
Expand All @@ -329,6 +310,12 @@ export function Discover() {
setIsHovered(false);
};

useEffect(() => {
if (!isHovered) {
document.body.style.overflow = "auto";
}
}, [isHovered]);

function renderMovies(medias: Media[], category: string, isTVShow = false) {
const categorySlug = `${category.toLowerCase().replace(/ /g, "-")}${Math.random()}`; // Convert the category to a slug
const displayCategory =
Expand Down
Loading